Update correlation penalty for EIP-7251 #14456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
update-correlation-penalty
branch
from
c059a20 to
5f54320
Compare
terencechain
force-pushed
the
update-correlation-penalty
branch
15 times, most recently
from
6d89f55 to
9fb665c
Compare
james-prysm
reviewed
Sep 25, 2024
| // Modified in Electra:EIP7251 | ||
| var penaltyPerEffectiveBalanceIncrement uint64 | ||
| if st.Version() == version.Electra { | ||
| penaltyPerEffectiveBalanceIncrement = minSlashing / (totalBalance / increment) |
There was a problem hiding this comment.
can (totalBalance / increment) ever be 0?
There was a problem hiding this comment.
no, I dont think it can
terencechain
force-pushed
the
update-correlation-penalty
branch
from
9fb665c to
2ecf5cb
Compare
james-prysm
reviewed
Sep 30, 2024
| penaltyNumerator := val.EffectiveBalance() / increment * minSlashing | ||
| penalty := penaltyNumerator / totalBalance * increment | ||
| var penalty uint64 | ||
| if st.Version() == version.Electra { |
There was a problem hiding this comment.
should we do st.Version() >= version.Electra? might not change next hard fork
potuz
reviewed
Sep 30, 2024
|
|
||
| // Modified in Electra:EIP7251 | ||
| var penaltyPerEffectiveBalanceIncrement uint64 | ||
| if st.Version() == version.Electra { |
There was a problem hiding this comment.
The future me wants this :)
Suggested change
| if st.Version() == version.Electra { | |
| if st.Version() >= version.Electra { |
james-prysm
previously approved these changes
Oct 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
terencechain
force-pushed
the
update-correlation-penalty
branch
from
dccb780 to
e541901
Compare
terencechain
force-pushed
the
update-correlation-penalty
branch
from
e541901 to
b196f21
Compare
james-prysm
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the correlation penalty computation that caused a zero penalty for 32 ETH validators and a non-zero penalty for 2048 ETH validators under certain slashed balances, leading to an imbalance. The fix ensures penalties are computed per effective balance increment, preventing overflow and balancing penalties for different validator sizes.
Reference: ethereum/consensus-specs#3882