-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: switched from inversify to nestjs #626
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Various comments, mostly related to handling of silly
log levels.
Local testing will be required for this, I'm not 100% convinced that the rabbit queues stuff will continue to work with this change, there's a lot of moving parts that, while only IoC in theory has been changed, the effect of singletons (and I'm not seeing now they're declared yet) has drastic effects on the processing.
This reverts commit 6775f35.
…attempt to store a local cache of it for multiple lattice versions. Moved calculation of lattice version to the constants repo for common calculations. Removed hacking of Oshur data as Census provides it properly now.
Removed local server time calculations, throwback to when we used to factor in server time in brackets (which we no longer do)
…pace them. This has a benefit that Medis can group keys together for ease of administration. Refactored how census cache hits are recorded. Removed keys used in one place to describe lists and moved into their respective classes
Removed some extra logging or moved to logger
Corrected duration logic for census cache hits / misses
…named Census cache/miss to be more grammatically correct
Removed k8s templates that no longer used
Inversify while really feature rich is just a terrible idea for this project. I refactored the code with minimal changes so it uses NestJS, which is inline with other projects like the API and the Kafka collector. We are also able to use the full arsenal of what NestJS has to offer like microservices for instance.
Some items require attention:
body-parser
,cli-color
,clone
, andcors
;All in all I found some looming problems while working on this which are addressed now.
Btw, the biggest changes are in the services as I added some modules there. There is also the subscribers from rabbit that have been moved to the root.