Skip to content

Commit

Permalink
Increase buffer size of usb util game name
Browse files Browse the repository at this point in the history
  • Loading branch information
KrahJohlito authored Aug 10, 2021
1 parent 17c3a5c commit 2b2a87f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion include/supportbase.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ typedef struct

typedef struct
{
char name[UL_GAME_NAME_MAX];
char name[UL_GAME_NAME_MAX + 1];
char startup[15];
u8 parts;
u8 media; // Disc type
Expand Down

1 comment on commit 2b2a87f

@blckbearx
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this commit seems to break displaying and loading of USB Util format games.

I compiled the latest source code and got this errors:
WhatsApp Image 2021-08-10 at 20 41 27 (2)
WhatsApp Image 2021-08-10 at 20 41 27 (1)
WhatsApp Image 2021-08-10 at 20 41 27

and when trying to load the games it either gets stuck in the "Loading config..." screen or just displays an error.

I then recompiled but with this commit reverted and everything works just fine.

Is this commit part of a group of upcoming commits or PR? If not, either USB Util software needs to change in order to correctly save the games's names to the .cfg file or revert this commit in order to keep using the tool as-is (or change more stuff in order to properly load the names with this increased name size).

Please sign in to comment.