Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPL: Last commit about revision, i hate it now #15

Merged
merged 1 commit into from Oct 24, 2016
Merged

OPL: Last commit about revision, i hate it now #15

merged 1 commit into from Oct 24, 2016

Conversation

Caio99BR
Copy link
Contributor

@Caio99BR Caio99BR commented Oct 24, 2016

Checklists for Pull requests

About pull request itself:

  • I am submitting a pull request:)
  • My submission does one logical thing only (one bugfix, one new feature). If I will want to supply multiple logical changes, I will submit multiple pull requests.

Code quality:
(not applicable for non-code fixes of course)

Commits:

  • My commits are logical, easily readable, with concise comments.
  • My commits follow the KISS principle: do one thing, and do it well.

Licensing:

  • I am the author of submission or have been authorized by submission copyright holder to issue this pull request.

Branching:

  • My submission is based on master branch.
  • My submission is compatible with latest master branch updates (no conflicts, I did a rebase if it was necessary).
  • The name of the branch I want to merge upstream is not 'master' (except for only the most trivial fixes, like typos and such).
  • My branch name is feature/my-shiny-new-opl-feature-title (for new features).
  • My branch name is bugfix/my-totally-non-hackish-workaround (for bugfixes).
  • My branch name is doc/what-i-did-to-documentation (for documentation updates).

Continuous integration:

  • [TODO] Once I will submit this pull request, I will wait for Travis-CI report (normally a couple of minutes) and fix any issues I might have introduced.
  • [TODO] Until TravisCI not is configured, you can configure and run TravisCI https://travis-ci.org/, it alrealdy have a working template.

Pull request description

TravisCI:

  • Use file_glob to pickup files

Makefile:

  • Tested and Fix REVISION
  • Add packing of zip to RELEASE builds

lng_pack.sh:

  • Rework pickup of REVISION

Signed-off-by: Caio Oliveira caiooliveirafarias0@gmail.com

TravisCI:
* Use file_glob to pickup files

Makefile:
* Tested and Fix REVISION
* Add packing of zip to RELEASE builds

lng_pack.sh:
* Rework pickup of REVISION

Signed-off-by: Caio Oliveira <caiooliveirafarias0@gmail.com>
@doctorxyz doctorxyz merged commit 6d24b8d into ps2homebrew:master Oct 24, 2016
@Caio99BR Caio99BR deleted the bugfix/revision branch October 24, 2016 09:36
uyjulian pushed a commit that referenced this pull request Jul 22, 2021
AKuHAK added a commit that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants