Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMB update #196

Merged
merged 4 commits into from
Feb 12, 2019
Merged

SMB update #196

merged 4 commits into from
Feb 12, 2019

Conversation

sp193
Copy link
Contributor

@sp193 sp193 commented Feb 12, 2019

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK
  • Requires update of the gsKit
  • Others (please specify below)

Pull Request description

The custom lwip_recvfrom() function is no longer used.
Transmissions are limited to 65535 bytes, while receiving operations are limited to 4096 (TCP receive window is 5120, according to lwipopts.h).
This is to avoid triggering the TCP congestion avoidence algorithm of the SMB server.
…ime option that disables the building of unneeded functions at compile-time.
@ElPatas1 ElPatas1 merged commit 6836e5e into ps2homebrew:master Feb 12, 2019
@Jay-Jay-OPL
Copy link
Contributor

Jay-Jay-OPL commented Feb 13, 2019

@sp193 -- I'm aware that you pushed a few PRs, but so far I got to test up to this PR #196:

Open PS2 Loader 0.9.3+.1343-Beta-6836e5e

And I wanted to report that loading PS2 games from SMB is not working, plus I'd like to also point out that the PS2 LOGO doesn't display -- so that might be a clue?

If I enable the debug colors to flash it freezes up to the first debug color: magenta -- I don't think it ever gets a chance to display the PS2 LOGO. Since it's the first debug color.

UPDATE:

I see now that you have a new PR #198 waiting to get approved, I will also check that out to see if it fixes that.

In case it doesn't, can you tell us if we need to also update our PS2SDK? Since, I've noticed it has new changes, but none of your recent PR tells us if updating PS2SDK is required -- unless you forgot to check the box on all of them? Do let us know?

@sp193 sp193 deleted the smb-update branch February 15, 2019 14:39
AKuHAK pushed a commit that referenced this pull request Sep 30, 2021
citronalco pushed a commit to citronalco/OPL-Daily-Builds that referenced this pull request Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants