Flip insecure expose_php & register_globals values #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, so the tricky part here is that the "fix" handling should tell you to set it to "0" but the "notequals" evaluation should still be "1". Seems like maybe the issue is somewhere else in the "fix" flow... |
|
@dannykopping any feedback on this one in response to my question? Sorry, it's been a while since this conversation started, just wanted to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
iniscan fix, the suggested values forexpose_php®ister_globalsare incorrect.I'm not a security expert, but I believe the consensus on these values is that they should always be turned off.