Extract formatting tests #1785
Merged
Extract formatting tests #1785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
reviewed
Oct 25, 2020
| pytest-cases >= 2.3.0 | ||
| coverage >= 5.3 | ||
| parameterized >= 0.7.4 |
There was a problem hiding this comment.
Rather then adding a new dependency, can @pytest.mark.parametrize be used to do the same thing?
There was a problem hiding this comment.
It can, but it has been requested specifically to avoid using pytest in tests directly in order to allow people to use the testing platform of their choosing.
I personally prefer using pytest at any time, but I respect the design decisions of this project.
There was a problem hiding this comment.
My main pytest dislike is it's magical patching of thing so I guess the adding of a dep to allow both testing systems to be used works. Especially when this refactor is a big win imo.
|
@cooperlees, any feedback on this? |
cooperlees
approved these changes
Oct 30, 2020
3 tasks
noxan
pushed a commit
to noxan/black
that referenced
this pull request
Jun 6, 2021
* Update test versions * Use parametrize to remove tests duplications * Extract sources format tests * Fix mypy errors * Fix .travis.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the tests in Black are exact duplications of other tests.
In order to remove some of the duplications, added 2 parametrized tests that combine those tests.