Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line breaks before logical operators #36

Merged
merged 2 commits into from
Mar 17, 2018
Merged

Line breaks before logical operators #36

merged 2 commits into from
Mar 17, 2018

Conversation

autophagy
Copy link
Member

This addresses #21 where the PEP 8 guidelines state that it's preferred for lines to be broken before a logical operator, rather than afterwards.

However, flake8 yells at me with W503 line break before binary operator, so 😅

@autophagy
Copy link
Member Author

According to beetbox/beets#2687 (comment) W503 ignored by default anyways, but if you define an ignore list yourself it overwrites the defaults, so I've added it back in for this PR.

@ambv
Copy link
Collaborator

ambv commented Mar 17, 2018

This is amazing. Thanks a ton! 👍

Since you have a fresh view at this project, can you share what you found surprising, badly commented (incl. docstrings), etc.? We can improve things for future newcomers!

@ambv ambv merged commit 47ae92c into psf:master Mar 17, 2018
@ambv
Copy link
Collaborator

ambv commented Mar 17, 2018

Seal of Approval

@njsmith
Copy link

njsmith commented Mar 17, 2018

Sweet, thank you!

@autophagy autophagy deleted the operand-beginning-of-line branch March 17, 2018 12:02
@autophagy
Copy link
Member Author

@ambv I actually found the docstrings really well written and helpful, and everything else was pretty intuitive (also everything is named really well, which helps!)

I think the only thing, and this is more of a personal preference, but huge single-file python scripts can be a little intimidating! I dont know if splitting it up into logical components would make much sense, but yeah, with one large python file I find it a little difficult to grasp the structure at a glance 🙂

ambv pushed a commit that referenced this pull request Mar 19, 2018
madsbk added a commit to madsbk/ucx-py that referenced this pull request Apr 15, 2020
madsbk added a commit to madsbk/ucx-py that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants