Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort DEFAULT_EXCLUDES and add .vscode, .pytest_cache and .ruff_cache #3691

Merged
merged 3 commits into from
May 17, 2023

Conversation

raybellwaves
Copy link
Contributor

@raybellwaves raybellwaves commented May 17, 2023

Description

I would like to expand the excluded files/folder given in the default value (DEFAULT_EXCLUDES).

I would like to exclude the folders of .vscode, .pytest_cache and .ruff_cache. I tend to add these in the exclude arg of [tool.black] in my project.toml files. I can't see others wanting to run black on these unless i'm mistaken. I'm therefore wanted to upstream my excludes and save potential work for others who add this to configurations excludes.

To make it easier to add files/folders in the future I sorted the the inputs of DEFAULT_EXCLUDES.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary? - NA
  • Add new / update outdated documentation? - NA

@@ -1,4 +1,4 @@
DEFAULT_LINE_LENGTH = 88
DEFAULT_EXCLUDES = r"/(\.direnv|\.eggs|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv|venv|\.svn|\.ipynb_checkpoints|_build|buck-out|build|dist|__pypackages__)/" # noqa: B950
DEFAULT_EXCLUDES = r"/(\.direnv|\.eggs|\.git|\.hg|\.ipynb_checkpoints|\.mypy_cache|\.nox|\.pytest_cache|\.ruff_cache|\.tox|\.svn|\.venv|\.vscode|__pypackages__|_build|buck-out|_build|dist|venv)/" # noqa: B950
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_build is duplicated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the spot

@github-actions
Copy link

diff-shades reports zero changes comparing this PR (cae661d) to main (dc188f2).


What is this? | Workflow run | diff-shades documentation

@ichard26 ichard26 merged commit db3668a into psf:main May 17, 2023
jsh9 added a commit to jsh9/cercis that referenced this pull request May 21, 2023
commit eedfc38
Author: Jason R. Coombs <jaraco@jaraco.com>
Date:   Fri May 19 13:00:29 2023 -0400

    Avoid EncodingWarning in blib2to3 (psf#3696)

commit 2fd9d8b
Author: Jonathan Berthias <jvberthias@gmail.com>
Date:   Fri May 19 01:57:17 2023 +0200

    Remove blank lines before class docstring (psf#3692)

commit db3668a
Author: Ray Bell <rayjohnbell0@gmail.com>
Date:   Tue May 16 22:47:45 2023 -0400

    Sort DEFAULT_EXCLUDES and add .vscode, .pytest_cache and .ruff_cache (psf#3691)

    Co-authored-by: Ray Bell <ray.bell@dtn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants