fix: resolve symlinks when checking which files to format #4215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
find_project_root()
resolves symlinks, butget_sources()
doesn't, so trying to format a file that contains symlinks will fail:This commit changes methods used in
get_sources()
to, likefind_project_root()
, usePath.resolve()
instead ofPath.absolute()
, which will follow symlinks.Also fixes:
black
ignores file in current folder if current folder isgit
workspace and (parent of) current folder is a symbolic link #4205Checklist - did you ...
CHANGES.md
if necessary?