-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows: add a release workflow #308
Conversation
Co-authored-by: Frost Ming <mianghong@gmail.com>
Maybe add a https://packaging.python.org/en/latest/tutorials/packaging-projects/#creating-pyproject-toml |
Sounds good. Want me to move the whole |
Sure, if the config can be read from |
Removes setup.{cfg,py} in favor of pyproject.toml, and consolidates all settings.
Required with PEP 517/8 metadata.
Also, remove MANIFEST.in.
I'll merge on top of #312, since that will probably land first. @ionrock: I know you have limited bandwidth, but would you be able to look into configuring the trusted publisher on PyPI needed for this PR? Here's the configuration you'll need:
|
@woodruffw Done! |
@woodruffw I'm assuming you're going to add the |
Thanks @ionrock!
Yep, it should be included in this PR's changeset: https://github.com/psf/cachecontrol/pull/308/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34 |
This should be good to go whenever. @frostming, I assume we'll want to merge your 3.7 changes first. |
@frostming I'll do a pre-release to test the CI here after this is merged, unless you have any objections 🙂 |
@woodruffw Go ahead, let's also update the Makefile and include a dev guide for releasing. |
@ionrock Any chance to yank 0.13.0 to prevent users on Python 3.6 from installing this version(yeah we didn't know the context of yanking 0.12.12). We are not able to do this. @woodruffw If the version is yanked we should be able to release this as 0.13.1 |
@frostming Yanked! |
Okay, pushed up some initial contributing docs (in the I've removed the old |
@woodruffw what about https://pypi.org/project/bumpver which should be a drop-in replacement for |
Works for me -- I'll look at adding it tomorrow. |
* workflows: add a release workflow * Update .github/workflows/release.yml Co-authored-by: Frost Ming <mianghong@gmail.com> * treewide: pyproject-based metadata Removes setup.{cfg,py} in favor of pyproject.toml, and consolidates all settings. * pyproject: fix typo * tox: use isolated builds Required with PEP 517/8 metadata. * pyproject: include `build` in dev-deps * pyproject: include tests in sdist Also, remove MANIFEST.in. * meta: dedupe version, use `bump` * Makefile, pyproject: remove bump * CONTRIBUTING: initial contributing docs --------- Co-authored-by: Frost Ming <mianghong@gmail.com>
This adds a release workflow that runs on a
release: published
event, with both PyPI uploading (via trusted publishing) and code signing (via Sigstore). I kept the latter because I copied this from some other projects that I use the same workflow on, but I'm happy to remove it in the interest of keeping things minimal to begin with.Also, correcting myself from earlier: it looks like I don't have permissions to register the trusted publisher on the PyPI side:
Given that, I'll mark this as blocked until @ionrock can register the publisher (or grant me or @frostming the ability to do it ourselves).