Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently atop #90There's an implicit assumption that any QCEngine interaction with optking is through AtomicInput/AtomicResult/compute(atin, program) . I'm adding a new procedure to qcengine called qcmanybody that can supply gradients from many-body-expansion levels or bsse treatments. This is no different from what optking already works with in Psi4.
By placing in QCEngine, cp-corrected optimizations can be run with any qc program to supply the MBE subsystem atomicinput/result gradients. To get this going, there's ManyBodyInput/Result schema in qcmanybody and also a GeneralizedOptimizationInput/Result when the trajectory can be
Union[AtomicResult, ManyBodyResult]
. Then in MolSSI/QCEngine#448, there's a generalized optking procedure. (The "generalized" objects aren't forever; I just don't want to change things too suddenly.) Generalized schema are at https://github.com/MolSSI/QCManyBody/blob/main/qcmanybody/models/generalized_optimization.py . Note a qcel edit at MolSSI/QCManyBody#25The changes for optking are in this PR. It's not the cleanest but is pretty light. All existing tests pass locally. I wanted to get this on your radar.