Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Linux Builds #1752

Merged
merged 5 commits into from
Nov 15, 2019
Merged

Azure Linux Builds #1752

merged 5 commits into from
Nov 15, 2019

Conversation

dgasmith
Copy link
Member

@dgasmith dgasmith commented Nov 13, 2019

Description

The plan is to switch away from TravisCI Linux builds to Azure for unlimited build minutes, the ability to host more complex pipelines, and to prevent splitting between multiple services.

Status

  • Ready for review
  • Ready for merge

.azure-pipelines/azure-pipelines-windows.yml Show resolved Hide resolved
conda install qcelemental ^
qcengine ^
pybind11 ^
-c conda-forge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why c-f not psi4/label/dev?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this from Travis.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figure out why it's from c-f. this makes sure psi is using latest, even if I'm behind on psi4-dev packages.

.azure-pipelines/azure-pipelines-linux.yml Outdated Show resolved Hide resolved
.azure-pipelines/azure-pipelines-linux.yml Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2019

This pull request introduces 1 alert when merging 2dafcca into dfb86f5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2019

This pull request introduces 1 alert when merging f40c04b into dfb86f5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2019

This pull request introduces 1 alert when merging 59bf004 into dfb86f5 - view on LGTM.com

new alerts:

  • 1 for Unused import

Copy link
Contributor

@robertodr robertodr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks a lot! 🎉 🎊

@dgasmith
Copy link
Member Author

@psi4/admins Ready to review!

Copy link
Member

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great! maybe we can run codecov on PRs and not leave full test testing only to conda-build time.

@robertodr
Copy link
Contributor

I'll close #1748, but is the plan to use Ninja also on Linux/macOS?

@robertodr robertodr mentioned this pull request Nov 15, 2019
4 tasks
@dgasmith
Copy link
Member Author

It didn't seem to help much on Travis or am I wrong there? Very on board with ninja overall, just balancing the complexity.

@robertodr
Copy link
Contributor

That's correct, not much help on Travis. I was under the impression it was going to be a requirement when moving to libint2. But I can have a go at it later, once this is merged.

Copy link
Member

@jturney jturney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@robertodr
Copy link
Contributor

Someone should let Travis know they're not required anymore 😺

@dgasmith
Copy link
Member Author

Travis and GitHub has been informed!

@dgasmith dgasmith merged commit e135e6b into psi4:master Nov 15, 2019
@dgasmith dgasmith deleted the azure branch November 15, 2019 21:08
@loriab loriab added this to the Psi4 1.4 milestone Nov 22, 2019
@loriab loriab mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants