Avoid fetching thousands of pages from GitLab API #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you comment on an issue in a project that has thousands of issues, or operate on a merge request in a project with thousands of MRs, did attempts to fetch them all to identify the ID of the one you interacted with. This is OK for projects that are small in size, but becomes a huge issue for large projects such as https://gitlab.com/gitlab-org/gitlab, which has 218k issues. Check for the number of pages that would be fetched and avoid loading them all if there are more than 20 pages. This will lead to issue and merge request IDs missing from the report, but it will allow the report to finish within your lifetime. Signed-off-by: Clemens Lang <cllang@redhat.com>
neverpanic
force-pushed
the
cllang-gitlab-large-projects
branch
from
85d998f
to
37e6727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you comment on an issue in a project that has thousands of issues, or operate on a merge request in a project with thousands of MRs, did attempts to fetch them all to identify the ID of the one you interacted with.
This is OK for projects that are small in size, but becomes a huge issue for large projects such as https://gitlab.com/gitlab-org/gitlab, which has 218k issues.
Check for the number of pages that would be fetched and avoid loading them all if there are more than 20 pages. This will lead to issue and merge request IDs missing from the report, but it will allow the report to finish within your lifetime.