Switch to using Archive::Zip and Archive::Tar to extract archives.
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Archive::Extract` module is not safe with zip files and can extract files outside of the current working directory (assuming the server has write permission to do so). The `Archive::Zip` and `Archive::Tar` modules will not extract outside of the current working directory (by default). Additionally, using the `Archive::Zip` and `Archive::Tar` modules gives more power for archive extraction. If the "Overwrite existing files silenetly" checkbox is not checked, then this now checks each file in the archive to see if extracting it will overwrite an existing file. If so it refuses to do so, and a message is displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Archive::Extractmodule is not safe with zip files and can extract files outside of the current working directory (assuming the server has write permission to do so).The
Archive::ZipandArchive::Tarmodules will not extract outside of the current working directory (by default).Additionally, using the
Archive::ZipandArchive::Tarmodules gives more power for archive extraction. If the "Overwrite existing files silenetly" checkbox is not checked, then this now checks each file in the archive to see if extracting it will overwrite an existing file. If so it refuses to do so, and a message is displayed.