BF: prevent conversion of lower y-axis limit to -inf #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If velocities are plotted in logspace, a lower limit of 0 would be transformed to -inf - which results in a pyplot warning and y-axis limits to be ignored. This sets the default lower limit to 1, warns if it encounteres a lower limit of 0 and sets it to 1 instead.
|
ping @mih because you are not watching this repo. |
|
merging this. |
|
(we need to keep in mind to add this to a changelog in a future release @mih) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If velocities are plotted in logspace, a lower limit of 0
would be transformed to -inf - which results in a pyplot
warning and y-axis limits to be ignored. This sets the
default lower limit to 1, warns if it encounteres a lower
limit of 0 and sets it to 1 instead.
Fixes #14.