Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test across Python 3.8 or later in GitHub Actions workflow #24

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

jptomoya
Copy link
Contributor

@jptomoya jptomoya commented Feb 18, 2024

Test across Python 3.8 or later in GitHub Actions workflow

What's this Pull Request for?

Choose one or more of the following items.

  • Bug fix
  • Add/Remove feature
  • Cleaning code (including optimization/typo fix)
  • Others

Please explain the detail here:
Testing across Python versions 3.8 to 3.12 in the GitHub Actions workflow to identify version-specific issues.
Notably, warnings have been observed in Python 3.12 (see build (3.12) summary):

/home/runner/work/ptrlib/ptrlib/ptrlib/arch/intel/disassembler.py:65: SyntaxWarning: invalid escape sequence '\s'
  op = re.sub("\s+", " ", op.strip())
/home/runner/work/ptrlib/ptrlib/ptrlib/arch/arm/disassembler.py:70: SyntaxWarning: invalid escape sequence '\s'
  op = re.sub("\s+", " ", op.strip())

Also fixed Node.js 16 actions deprecated warnings.

What have you done so far?

Tell me what you've tested to assure your change is right.

  • All tests passed on your machine (python -m unittest)
  • Added test cases for new feature
  • Nothing / Test not required

(It's not mandatory to check even one of them, but test cases make it easy for the author to review your PR.)

Comment

You can view the pytest results on the job summary page :)

@ptr-yudai
Copy link
Owner

LGTM!

@ptr-yudai ptr-yudai merged commit fa9df75 into ptr-yudai:master Feb 19, 2024
5 checks passed
@jptomoya jptomoya deleted the improve-ci branch February 19, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants