Fix function type signatures #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change suppresses the following mypy errors:
ptrlib/binary/packing/chunks.py:29: error: Unsupported operand types for * ("_U" and "int") [operator]
ptrlib/binary/packing/chunks.py:29: note: Left operand is of type "_T | _U"
But the following mypy errors remain:
ptrlib/binary/packing/chunks.py:25: error: Argument 1 to "len" has incompatible type "_T"; expected "Sized" [arg-type]
ptrlib/binary/packing/chunks.py:26: error: Value of type "object" is not indexable [index]
ptrlib/binary/packing/chunks.py:28: error: Argument 1 to "len" has incompatible type "_T"; expected "Sized" [arg-type]
ptrlib/binary/packing/chunks.py:29: error: Unsupported operand types for * ("_T" and "int") [operator]
ptrlib/binary/packing/chunks.py:29: error: Argument 1 to "len" has incompatible type "_T"; expected "Sized" [arg-type]
This change suppresses the following mypy errors:
ptrlib/binary/packing/flat.py:12: error: Overloaded function implementation does not accept all possible arguments of signature 1 [misc]
ptrlib/binary/packing/flat.py:24: error: Argument 1 has incompatible type "list[_T] | _T"; expected "_T" [arg-type]
ptrlib/binary/packing/flat.py:26: error: No overload variant of "__add__" of "list" matches argument type "_T" [operator]
ptrlib/binary/packing/flat.py:26: note: Possible overload variants:
ptrlib/binary/packing/flat.py:26: note: def __add__(self, list[_U], /) -> list[_U]
ptrlib/binary/packing/flat.py:26: note: def [_S] __add__(self, list[_S], /) -> list[_S | _U]
ptrlib/binary/packing/flat.py:26: note: def __add__(self, list[_T], /) -> list[_T]
ptrlib/binary/packing/flat.py:26: note: def [_S] __add__(self, list[_S], /) -> list[_S | _T]
ptrlib/binary/packing/flat.py:26: error: Unsupported left operand type for + ("_T") [operator]
ptrlib/binary/packing/flat.py:26: note: Both left and right operands are unions
ptrlib/binary/packing/flat.py:26: error: Incompatible types in assignment (expression has type "list[_U] | list[_T | _U] | Any | list[_T]", variable has type "list[_U] | list[_T] | _T") [assignment]
ptrlib/binary/packing/flat.py:26: error: Argument 1 has incompatible type "list[_T] | _T"; expected "_T" [arg-type]
ptrlib/binary/packing/flat.py:28: error: Incompatible return value type (got "list[_U] | list[_T] | _T", expected "list[_T] | list[_U]") [return-value]
But the following mypy errors remain:
ptrlib/binary/packing/flat.py:26: error: Unsupported left operand type for + ("object") [operator]
ptrlib/binary/packing/flat.py:28: error: Incompatible return value type (got "object", expected "_T | _U") [return-value]
mypy can't infer that the return value should be int in the following code, even if using overload. def u32(..., result_type: Type[_T]=int) -> _T: Since result_type is already deprecated and u32/u64 return as int in many cases, change type signatures for convenience.
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix function type signatures
What's this Pull Request for?
Choose one or more of the following items.
Please explain the detail here:
What have you done so far?
Tell me what you've tested to assure your change is right.
python -m unittest)(It's not mandatory to check even one of them, but test cases make it easy for the author to review your PR.)
Comment