refactor: two small cleanups that were bothering me. #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Eh2406
changed the title
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Sorry for the spam, I'm taking this trivial PR as an opportunity to explore the new CI merged queue set up. |
zanieb
pushed a commit
to astral-sh/pubgrub
that referenced
this pull request
Nov 8, 2023
This was referenced Nov 15, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two small things that I keep running across and are off-topic for other PR's, and two small for their own PR. But if it's ever getting it fixed... here is a PR.
<1, >=2, <=2, >3is tricky to parse visually. My brain keeps trying to figure out what(<1 and >=2) or (<=2 and >3)means. The core issue is that,sometimes meansandand other times meansor. So this changes to using|for or.