Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy "location search" feature to archive.html #1272

Closed
jywarren opened this issue Nov 16, 2022 · 4 comments · Fixed by #1286
Closed

Copy "location search" feature to archive.html #1272

jywarren opened this issue Nov 16, 2022 · 4 comments · Fixed by #1286

Comments

@jywarren
Copy link
Member

We have this great new feature for searching for locations:

https://publiclab.github.io/Leaflet.DistortableImage/examples/

image

However we want that same feature at the archive page:

https://publiclab.github.io/Leaflet.DistortableImage/examples/archive.html

It should be a pretty easy change! Here are the changes to index.html that made it possible: https://github.com/publiclab/Leaflet.DistortableImage/pull/1158/files

I'd love help with this! Maybe it could even be a first-timers-only issue?

@jywarren
Copy link
Member Author

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!


@rit-clone
Copy link

Hi @jywarren I would love to work on this issue. Will you please assign it to me?

@jywarren
Copy link
Member Author

jywarren commented Nov 25, 2022 via email

@hs05june
Copy link
Contributor

hs05june commented Dec 4, 2022

https://github.com/publiclab/Leaflet.DistortableImage/pull/1286 Hey @jywarren . Once check my PR. I was struggling on a bug. I was unable to figure that out. Kindly suggest something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants