Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage grunt task from Gruntfile.js #537

Closed
sashadev-sky opened this issue Jan 26, 2020 · 4 comments
Closed

Fix coverage grunt task from Gruntfile.js #537

sashadev-sky opened this issue Jan 26, 2020 · 4 comments

Comments

@sashadev-sky
Copy link
Member

sashadev-sky commented Jan 26, 2020 •
edited
Loading

  • Currently the coverage folder is created outside of the repository in its parent folder.
    1. Create it in the repository directory
    2. Possibility to collapse inner Phantom folder that holds all the files we need so its just coverage/phantom/files

also other potential followups for webpack config:

  • add compress: true to devServer to enable GZIP compression?
@sashadev-sky sashadev-sky changed the title Remove coverage grunt task from package.json Remove coverage grunt task from Gruntfile.js Jan 26, 2020
@sashadev-sky
Copy link
Member Author

@jywarren @VladimirMikulic @rexagod

@sashadev-sky sashadev-sky mentioned this issue Jan 27, 2020
Merged
@VladimirMikulic
Copy link
Contributor

It doesn't really make sense to compress assets in development server.

It will just slow it down, hence development server, not the production one :)

@sashadev-sky
Copy link
Member Author

Wont it speed up page load, though, hence a faster development experience and one that is closer to the production experience? (FYI always here to learn so don't be shy to tell me i'm wrong)

@sashadev-sky sashadev-sky changed the title Remove coverage grunt task from Gruntfile.js Fix coverage grunt task from Gruntfile.js Jan 27, 2020
@VladimirMikulic
Copy link
Contributor

VladimirMikulic commented Jan 27, 2020 •
edited
Loading

@sashadev-sky I am glad you ask.
I agree with you up to the point, the bandwidth will be saved, but we are putting the load on the processor.
Again, if you have i7 it doesn't matter, but if you are on Athlon Dual Core it does for sure.
The same applies to the network :)

hot option serves this purpose, update the changes without browser reload.

The usual practice is to compress on the final build, but if you insist I'll enable it.

sashadev-sky added a commit that referenced this issue Apr 13, 2020
@VladimirMikulic @sashadev-sky
ADD: Webpack module bundler to compile code from /src/ to /dist/ (#512)
c0ccff5 
* ADD: Webpack module bundler

Up to this point, we have been writing old ES5.
This change introduces Webpack, Webpack development server, Babel...
From now on, we will be able to write modern JavaScript.

Resolves #372

* UPDATE: README "Contributing" section

"Contributing" section updated to show project setup with Webpack.

* ADD: Webpack config file documentation

The documentation for the Webpack configuration file can be found in
WEBPACK.md

* ADD: "npm run build" to travis.yml

* ADD: leaflet.distortableimage.js to git tracker

Added to resolve merge conflict.

* UPDATE: Webpack.md

Fixed redundant spaces and a grammar issue.

* UPDATE: Project configuration files

Changes:
 - Add npm build script to pre-commit task
 - Remove redundant Grunt's "default" task
 - Empty line to .gitignore
 - Move vendor.css to load before our css
 - Change WDS port from 3000 to 8080
 - Update README.md

* ADD: "watch" Grunt task to run tests on change

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update WEBPACK.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* v0.12.6 🚀🚀🚀

* FIX: Karma tests coverage

Karma configuration modified to generate the coverage folder inside of
the working directory and without PhantomJS subfolder.

Minor change: browserlist update to include browsers with the usage >
0.2%

Resolves #537

* Rebase the branch

Co-authored-by: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>
sashadev-sky added a commit to carlo-ev/Leaflet.DistortableImage that referenced this issue Apr 14, 2020
@VladimirMikulic @sashadev-sky
ADD: Webpack module bundler to compile code from /src/ to /dist/ (pub…
2635876 
…liclab#512)

* ADD: Webpack module bundler

Up to this point, we have been writing old ES5.
This change introduces Webpack, Webpack development server, Babel...
From now on, we will be able to write modern JavaScript.

Resolves publiclab#372

* UPDATE: README "Contributing" section

"Contributing" section updated to show project setup with Webpack.

* ADD: Webpack config file documentation

The documentation for the Webpack configuration file can be found in
WEBPACK.md

* ADD: "npm run build" to travis.yml

* ADD: leaflet.distortableimage.js to git tracker

Added to resolve merge conflict.

* UPDATE: Webpack.md

Fixed redundant spaces and a grammar issue.

* UPDATE: Project configuration files

Changes:
 - Add npm build script to pre-commit task
 - Remove redundant Grunt's "default" task
 - Empty line to .gitignore
 - Move vendor.css to load before our css
 - Change WDS port from 3000 to 8080
 - Update README.md

* ADD: "watch" Grunt task to run tests on change

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update WEBPACK.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* Update README.md

Co-Authored-By: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>

* v0.12.6 🚀🚀🚀

* FIX: Karma tests coverage

Karma configuration modified to generate the coverage folder inside of
the working directory and without PhantomJS subfolder.

Minor change: browserlist update to include browsers with the usage >
0.2%

Resolves publiclab#537

* Rebase the branch

Co-authored-by: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VladimirMikulic @sashadev-sky