Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update export.html #1248

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Update export.html #1248

merged 4 commits into from
Oct 28, 2022

Conversation

olamideazeez
Copy link
Contributor

@olamideazeez olamideazeez commented Oct 27, 2022

Adding the closing body tag in the export.html file

Fixes #1218 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

Adding the closing body tag in the export.html file
@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2022

@olamideazeez
Copy link
Contributor Author

hello @TildaDares i have created a pull request

@olamideazeez
Copy link
Contributor Author

@segun-codes please kindly review

@segun-codes
Copy link
Collaborator

@segun-codes please kindly review

Hi @olamideazeez, sorry, reviews are done by our mentors. I am just an intern hopeful like you.

@7malikk
Copy link
Collaborator

7malikk commented Oct 27, 2022

@olamideazeez It looks good, should be merged at the nearest convenience
@segun-codes even as an intern, you can still review the works of others.
@TildaDares @cesswairimu would appreciate it

@segun-codes
Copy link
Collaborator

@olamideazeez It looks good, should be merged at the nearest convenience @segun-codes even as an intern, you can still review the works of others. @TildaDares @cesswairimu would appreciate it

Oh! nice... I thought reviewing his work could amount to crossing my bounds in this case as intern. Thanks @7malikk.

@TildaDares
Copy link
Member

Hi @olamideazeez, can you merge the changes in this PR and #1247 into a single PR as they both resolve the same issue. Thanks!

@olamideazeez
Copy link
Contributor Author

Hi @olamideazeez, can you merge the changes in this PR and #1247 into a single PR as they both resolve the same issue. Thanks!

hi @TildaDares please can i get a tip on how i can do that?

examples/export.html Outdated Show resolved Hide resolved
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @olamideazeez. Thank you!

@TildaDares TildaDares merged commit f866f96 into publiclab:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update files select.html and export.html with missing </body> tags
4 participants