-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update export.html #1248
Update export.html #1248
Conversation
Adding the closing body tag in the export.html file
hello @TildaDares i have created a pull request |
@segun-codes please kindly review |
Hi @olamideazeez, sorry, reviews are done by our mentors. I am just an intern hopeful like you. |
@olamideazeez It looks good, should be merged at the nearest convenience |
Oh! nice... I thought reviewing his work could amount to crossing my bounds in this case as intern. Thanks @7malikk. |
Hi @olamideazeez, can you merge the changes in this PR and #1247 into a single PR as they both resolve the same issue. Thanks! |
hi @TildaDares please can i get a tip on how i can do that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @olamideazeez. Thank you!
Adding the closing body tag in the export.html file
Fixes #1218 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!