Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nameless functions to arrow functions #1252

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

jssol
Copy link
Contributor

@jssol jssol commented Oct 27, 2022

Fixes #1235

Made sure these boxes are checked before the pull request (PR) is ready to be reviewed and merged.

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in a uniquely-named feature branch and has no merge conflicts 📁
  • @Achele, @TildaDares I have implemented the fix, and I would like to get a review.

Requirements

@welcome
Copy link

welcome bot commented Oct 27, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2022

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @jssol. Thank you!

@TildaDares TildaDares merged commit 2b51b89 into publiclab:main Oct 27, 2022
@welcome
Copy link

welcome bot commented Oct 27, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations on merging your PR @jssol 🎉🎉

@jssol
Copy link
Contributor Author

jssol commented Oct 28, 2022

Thanks for the review @TildaDares, I'm heading to the next steps 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change nameless functions to arrow functions
2 participants