-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed let to const in src/edit/DistortableImage.Edit.js #1318
Conversation
Thanks for opening this pull request! |
Hi @AtulyaJaiswal , thanks for opening this, could you please add a link to the issue this pull request fixes on the description --- On this this line |
@cesswairimu sir, I have updated the comment. |
no worries @AtulyaJaiswal, I meant the issue you are fixing with this PR, i believe it's this one #1309 right? and no biggie but my pronouns are she/her. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Thank you @cesswairimu for your valuable feedback. |
@TildaDares, I guess you want to consider merging this now. Many thanks! |
Thank you for the reviews @segun-codes @cesswairimu. Great work @AtulyaJaiswal 🚀 |
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Congratulations on your merge @AtulyaJaiswal 🎉 |
Thank you @segun-codes @TildaDares @cesswairimu @7malikk. |
Fixes #1318
I have updated the document from let to const in src/edit/DistortableImage.Edit.js .
I am sorry for the last comment, please don't mind as I am very new to open source and I was not aware how to write comment, very sorry for this.