Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed let to const in src/edit/DistortableImage.Edit.js #1318

Merged
merged 3 commits into from
Dec 25, 2022

Conversation

AtulyaJaiswal
Copy link
Contributor

@AtulyaJaiswal AtulyaJaiswal commented Dec 23, 2022

Fixes #1318

I have updated the document from let to const in src/edit/DistortableImage.Edit.js .
I am sorry for the last comment, please don't mind as I am very new to open source and I was not aware how to write comment, very sorry for this.

@welcome
Copy link

welcome bot commented Dec 23, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@cesswairimu
Copy link
Collaborator

Hi @AtulyaJaiswal , thanks for opening this, could you please add a link to the issue this pull request fixes on the description --- On this this lineFixes #0000 (replace 0000 with the issue number) this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@AtulyaJaiswal
Copy link
Contributor Author

@cesswairimu sir, I have updated the comment.
Sorry for the inconvenience.

@cesswairimu
Copy link
Collaborator

no worries @AtulyaJaiswal, I meant the issue you are fixing with this PR, i believe it's this one #1309 right? and no biggie but my pronouns are she/her.
Thanks

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@AtulyaJaiswal
Copy link
Contributor Author

Thank you @cesswairimu for your valuable feedback.

@segun-codes
Copy link
Collaborator

Thank you @cesswairimu for your valuable feedback.

@TildaDares, I guess you want to consider merging this now. Many thanks!

@TildaDares
Copy link
Member

Thank you for the reviews @segun-codes @cesswairimu.

Great work @AtulyaJaiswal 🚀

@TildaDares TildaDares merged commit 6ccad34 into publiclab:main Dec 25, 2022
@welcome
Copy link

welcome bot commented Dec 25, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@7malikk
Copy link
Collaborator

7malikk commented Dec 25, 2022

Congratulations on your merge @AtulyaJaiswal 🎉
Good job!

@AtulyaJaiswal
Copy link
Contributor Author

Thank you @segun-codes @TildaDares @cesswairimu @7malikk.

@AtulyaJaiswal AtulyaJaiswal deleted the newbranch branch December 26, 2022 02:28
@AtulyaJaiswal AtulyaJaiswal restored the newbranch branch December 26, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants