Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate node version 8 to fix travis test failures #609

Merged
merged 12 commits into from
Apr 15, 2020

Conversation

sashadev-sky
Copy link
Member

@sashadev-sky sashadev-sky commented Apr 15, 2020

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

=========================

Summary

  • Deprecate node version 8 (many of our dev dependencies deprecate it in their newer versions)

    • Support node versions 10, and 12 (12.16.2 is the LTS) right now.
  • Update packages that have a also deprecated node 8 in newer versions

  • Remove deprecated jshint attributes from Gruntfile.js

  • bump to 0.16.6

  • add below field to give warning to users:

"engines": {
    "node": ">=10.0.0"
  },

@sashadev-sky
Copy link
Member Author

sashadev-sky commented Apr 15, 2020

@jywarren @VladimirMikulic our travis tests have been pretty fickle with failures (see for ex. last commit to master https://travis-ci.org/github/publiclab/Leaflet.DistortableImage/jobs/675056848)
so i'm updating the node versions from 8, 10, and 12 -> 10 and 12. (8 is deprecated by karma, sinon, cross-env and 10 is the lowest active LTS).

@sashadev-sky sashadev-sky merged commit 0e6fcd6 into publiclab:main Apr 15, 2020
@jywarren
Copy link
Member

Hi, thank you! I also found some more issues related to this which I've documented in comments in #675, check it out!

@jywarren jywarren mentioned this pull request Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants