-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate node version 8 to fix travis test failures #609
Conversation
@jywarren @VladimirMikulic our travis tests have been pretty fickle with failures (see for ex. last commit to master https://travis-ci.org/github/publiclab/Leaflet.DistortableImage/jobs/675056848) |
Hi, thank you! I also found some more issues related to this which I've documented in comments in #675, check it out! |
Fixes #0000 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
=========================
Summary
Deprecate node version 8 (many of our dev dependencies deprecate it in their newer versions)
Update packages that have a also deprecated node 8 in newer versions
Remove deprecated jshint attributes from
Gruntfile.js
bump to 0.16.6
add below field to give warning to users: