Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed in DistortableImage.Keymapper- by removing the function #783

Merged
merged 1 commit into from
Nov 22, 2020
Merged

changed in DistortableImage.Keymapper- by removing the function #783

merged 1 commit into from
Nov 22, 2020

Conversation

shivarajloni
Copy link
Contributor

@shivarajloni shivarajloni commented Oct 24, 2020

Fixes #765 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Oct 24, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Oct 24, 2020

@shivarajloni
Copy link
Contributor Author

@sashadev-sky please review it! and merge it with tag, hacktoberfest and hacktoberfest-accepted

thank you!

@shivarajloni
Copy link
Contributor Author

@SMAKSS please add the tags- hacktoberfest and hacktoberfest-accepted

thank you

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivarajloni great job here!! Merging now, thanks!

@sashadev-sky sashadev-sky merged commit 00ceec2 into publiclab:main Nov 22, 2020
@welcome
Copy link

welcome bot commented Nov 22, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.DistortableImage.Keymapper method creation to ES6 syntax II
3 participants