Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching between modes leads to html tags rendering for center aligned text #524

Open
shreyaa-s-zz opened this issue Jun 5, 2020 · 10 comments

Comments

@shreyaa-s-zz
Copy link
Collaborator

Description:
Text is selected and center aligned. A string of text is selected with the center aligned text as substring and center aligned, and then switching to markdown mode. The selected part is rendered as HTML tags. Switching back to rich text editor leads to loss of data.

simplescreenrecorder-2020-06-05_17 13 06

(Test conducted on master branch)

What might be the probable causes?

@cypherean
Copy link
Contributor

@jywarren @emilyashley @VladimirMikulic @cesswairimu @Shulammite-Aso @NitinBhasneria @keshav234156 any idea why this might be happening? Or where to look for the error?

@cesswairimu
Copy link
Collaborator

cesswairimu commented Jun 11, 2020

@shreyaa-sharmaa great catch 💯 ... this is weird...tried a couple of other formatting like bold-ing and the table remains intact after bold-ing and switching back between the modes..also realized if you also center-align the table the data is not lost.. 🤔 no idea why this is happening..

@SteveSayantan
Copy link

As a beginner, I would like to work on this issue, can anyone help me by pointing out how and where to start? I have an intermediate level knowledge of JS . @cesswairimu @shreyaa-s-zz @jywarren

@cesswairimu
Copy link
Collaborator

Hi @SteveSayantan and welcome. We would love your help! Have you setup the project yet? if not, you can find the steps to install here under "Installation" also overall info about the project and the modules and how to run it can be found there. Feel free to reach out if you are stuck somewhere or have other questions. thanks

@SteveSayantan
Copy link

@cesswairimu thanks for the response!! Actually, I am having difficulty understand the code i.e. which file to change and how everything is working. Could you please suggest a beginners-friendly issue for getting started?
I have installed the repo and all the packages successfully.

@cesswairimu
Copy link
Collaborator

I see, I did go through the issues and my judgement on it being "beginner friendly" maybe flawed( not so good with js) but how does this one look #609 ? You may need to check if the issue is still persisting. thanks

@SteveSayantan
Copy link

Hey @cesswairimu I looked into the issue, but still can not figure out anything. Anyways, thanks for your response.

@cesswairimu
Copy link
Collaborator

Sorry @SteveSayantan I couldn't help much, Tagging @TildaDares, if you do come across any good JS second issue kindly tag @SteveSayantan

@TildaDares
Copy link
Member

Hi @cesswairimu, I opened an issue here publiclab/plots2#11246 and tagged @SteveSayantan. Let me know if you need any help with that issue.

@cesswairimu
Copy link
Collaborator

Awesome🎉🎉🎉. Thanks a bunch @TildaDares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants