Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish button loading behavior strange #609

Open
avats-dev opened this issue Sep 3, 2020 · 10 comments
Open

Publish button loading behavior strange #609

avats-dev opened this issue Sep 3, 2020 · 10 comments
Labels

Comments

@avats-dev
Copy link
Member

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

When there is some sort of error (like entering same title again), error message is displayed when one clicks on publish, but the button keeps loading even after the error message is displayed.

Like this:
Screenshot from 2020-09-02 23-19-18

What did you expect to see that you didn't?

After displaying the error, the button should again be like before, i.e. showing publish.

Please show us where to look

https://publiclab.org/post

What's your PublicLab.org username?

This can help us diagnose the issue:
Not relevant

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

OS : Ubuntu LTS 20.04
Browser : Firefox 80.0 (64 bit)


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@avats-dev avats-dev added the bug label Sep 3, 2020
@welcome
Copy link

welcome bot commented Sep 3, 2020

Thanks for opening your first issue! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots or a gif to share demonstrating the issue, that's really helpful! 📸
Do join our Gitter channel for some brainstorming discussions.

@sagarpreet-chadha
Copy link
Contributor

We should not enable the submit button if the title module throws this error. Would you like to work on this?

@avats-dev
Copy link
Member Author

@sagarpreet-chadha I would like to but as I'm still getting a hang of ruby's templating engine, this might take some time. Would it be a problem?

@sagarpreet-chadha
Copy link
Contributor

We do not need rails knowledge here, we will solve this issue here using vanilla JS, if you are comfortable with it, and bump version later 😄

@avats-dev
Copy link
Member Author

Ok

@cypherean
Copy link
Contributor

Hello!

Is anyone working on this?

@RuthNjeri
Copy link

Hi @shreyaa-sharmaa thank you for reaching out 😄
If you are interested in working on this issue please feel free to start working on it. You can ask any questions here if you need any clarification.

@cypherean
Copy link
Contributor

This looks like a priority issue hence my interest in any update.
I just wanted to make sure it is not reserved for newcomers. If it's not, I'll open a PR for the same.

@avats-dev
Copy link
Member Author

@cypherean sorry for the late response. It is not reserved for anyone as it has not been templated into an FTO or assigned to someone. You're free to either resolve this or create an FTO out of this for the newcomers, whichever you may prefer. Thanks for contributing to publiclab. 🎉

@RaviAnand111
Copy link
Contributor

Hey @avats-dev, is this issue still open, I would like to contribute to this issue, I am new but I am willing to learn and work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants