Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Tooltip to last 3 buttons #160

Merged
merged 3 commits into from
Nov 26, 2018
Merged

Conversation

DivyeshPuri
Copy link
Contributor

Fixes #156
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@DivyeshPuri
Copy link
Contributor Author

Please review @publiclab/reviewers

@DivyeshPuri
Copy link
Contributor Author

@jywarren @SidharthBansal Please review the PR

@grvsachdeva
Copy link
Member

hi @DivyeshPuri how about adding a GIF of the updated view. Thanks!

@DivyeshPuri
Copy link
Contributor Author

@gauravano Sure 😄
publiclabs

@jywarren
Copy link
Member

Oh this is super nice! But I think it may need to be rebased? I see:
image

@DivyeshPuri
Copy link
Contributor Author

@publiclab/reviewers @jywarren Please take a look.

@jywarren
Copy link
Member

This looks awesome. Would you be able to run grunt build and check in the new files generated into the dist folder? Then this should be good to go!

@DivyeshPuri
Copy link
Contributor Author

@jywarren Please Review

@jywarren
Copy link
Member

Great work here!!!! Thanks a million!

@jywarren jywarren merged commit 261fc98 into publiclab:master Nov 26, 2018
@jywarren
Copy link
Member

Would you be interested in investigating a new issue, like this one maybe? #142

@DivyeshPuri
Copy link
Contributor Author

@jywarren Sure. Will love to do that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover Text Not working
3 participants