New Navbar added with the logo of PublicLab

[YogeshSharma01]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[govindgoel]

@YogeshSharma01 Kindly share the preview of changes, is it referred to any issue kindly mention that too.

[YogeshSharma01]

Hi, @govindgoel sorry for the late reply actually I was busy with my exams. Here is a short video of changes.

Video--.mov

[jywarren]

Thank you, this looks so cool!

[jywarren]

Let's make this a tiny bit smaller -- can we do... half this size? Also, i don't see this image file, do you need to include it? https://github.com/publiclab/community-toolbox/tree/main/images

[YogeshSharma01]

Yes, I have set the size of the LOGO-IMG and also add an image file.
Thank you @jywarren

[YogeshSharma01]

Hi, @jywarren, @govindgoel I have set the size of the logo image. Please merge the PR.

[daemon1024]

Hi @YogeshSharma01 , thanks for the awesome work on this. I had a few pointers,

1. The navbar background is not consistent with the rest of the page in dark mode.
2. Is it possible to have the Fork me on github banner at the top of the page above navbar?

[jywarren]

Thank you!!! This is getting there -- i agree with @daemon1024's input, thank you!!

[YogeshSharma01]

Hi,
Thanks, @daemon1024 I have fixed the dark mode issue and also placed Fork me on GitHub banner at the top of the page above the navbar.
DAY Mode>>

NIGHT Mode>>

[jywarren]

This is really lovely!!! Thank you!! I'll go ahead and merge this now!!!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://code.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

[daemon1024]

Fixed #319

[jywarren]

Hi @YogeshSharma01 just a quick query - I'm testing this out in GitPod and seeing the following. I ran npm install -- am I missing some step to get the navbar formatting?

[YogeshSharma01]

Hi, @jywarren I debugged the code and found out this is an issue. The issue was introduced while resolving conflicts in the PR #422.

These are the issues that have found out.

1. There is duplicate code for the navbar and the headings of FTO and Contributors sections.
2. CSS file had a missing parenthesis due to which the whole page was misaligned.

These issues can be resolved easily. So, what do you suggest how do we push the changes?

[jywarren]

Hmm. Thank you so much for diagnosing this. If you are able to push a new PR i'd appreciate it, otherwise if you could open an issue describing this, we can see if someone else is able to make a fix. Thanks again!!!

…

On Fri, Mar 12, 2021 at 1:00 PM Yogesh Sharma ***@***.***> wrote: Hi, @jywarren <https://github.com/jywarren> I debugged the code and found out this is an issue. The issue was introduced while resolving conflicts in the PR #422 <#422>. These are the issues that have found out.. 1. There is duplicate code for the navbar and the headings of *FTO* and *Contributors* sections. 2. CSS file had a missing parenthesis due to which the whole page was misaligned. these issues can be resolved easily. So, what do you suggest how do we push the changes? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#420 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAF6JYHD6VJXBTTC4ISWLTTDJJD5ANCNFSM4VVRBOUA> .

[YogeshSharma01]

Hi, @jywarren my apologies for the late reply actually because of some medical emergency I wasn't able to reply ok I'll create a new issue for this.
Thanks

[jywarren]

I'm so sorry to hear that and best wishes. Please don't worry too much about this and be in touch when you're able to. ❤️