Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Safari #1738

Closed
jlev opened this issue Oct 22, 2020 · 3 comments · Fixed by #1740
Closed

Not working in Safari #1738

jlev opened this issue Oct 22, 2020 · 3 comments · Fixed by #1740

Comments

@jlev
Copy link

jlev commented Oct 22, 2020

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?

Load page, can't take or upload photos.
Console error "Invalid regular expression: invalid group specifier name"

Quick google search indicates that error message may be due to using look-behinds in regular expressions.
https://stackoverflow.com/questions/51568821/works-in-chrome-but-breaks-in-safari-invalid-regular-expression-invalid-group

Please show us where to look

https://beta.sequencer.publiclab.org

What's your PublicLab.org username?

This can help us diagnose the issue:

jlev

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

Mac OS 10.15.7
Safari 14.0


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@welcome
Copy link

welcome bot commented Oct 22, 2020

Thanks for opening your first issue here! This space is protected by our Code of Conduct - and we're here to help.
Please follow the issue template to help us help you 👍🎉😄
If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!
Don't forget to join our PublicLab Gitter channel and our ImageSequencer Gitter Channel for some brainstorming discussions.

@harshkhandeparkar
Copy link
Member

Can you tell which line of code is throwing the error?

@jlev
Copy link
Author

jlev commented Oct 26, 2020

Not in production, because there aren't source code maps published.

Running locally, the error I get is

[Error] SyntaxError: Invalid regular expression: invalid group specifier name
	(anonymous function) (image-sequencer.js:107485)

Which corresponds to the removeBackslashes function in picomatch.

Looks like it was fixed in micromatch/picomatch#15

jlev added a commit to jlev/image-sequencer that referenced this issue Oct 26, 2020
jywarren added a commit that referenced this issue Nov 2, 2020
* upgrade picomatch

for #1738

* fix: remove picomatch from package.json

Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>

Co-authored-by: Harsh Khandeparkar <34770591+HarshKhandeparkar@users.noreply.github.com>
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants