Module not found error in demo

[jywarren]

https://publiclab.github.io/image-sequencer/examples/#steps=import-image,blend,ndvi,colormap is returning Module not found. -- not sure why. Looking...

[jywarren]

GitMate.io thinks the contributor most likely able to help you is @tech4GT.

Possibly related issues are #145 ("reader is not defined" error on demo), #3 (CORS Image error on GitHub hosted demos), #142 (Add select dropdown for some module UIs in demo), #209 (Module info in demo should source from info.json), and #215 (Refine/simplify "add module" interface in demo).

[tech4GT]

@jywarren the url is not correct, The current format is channel(channel:green),invert() like this

[jywarren]

So then https://publiclab.github.io/image-sequencer/examples/#steps=import-image(url:0),blend(blend:function(r1%2C%20g1%2C%20b1%2C%20a1%2C%20r2%2C%20g2%2C%20b2%2C%20a2)%20%7B%20return%20%5B%20r1%2C%20g2%2C%20b2%2C%20a2%20%5D%20%7D),ndvi(filter:red),colormap(colormap:fastie)

OK - so because we're splitting on both comma and (, that's broken previous saved sequences, that's not good. I think we have to come up with a solution here...

[tech4GT]

@jywarren Oh I got it!! Fixing this now!! Sorry my bad!!

[jywarren]

Since we're now URL-encoding the functions, we can go back to splitting on , alone, and then:

• if there are no configurations specified OR
• the config is the default

then we can leave out the configs?

[jywarren]

No problem! I guess we should've added more thorough tests... when we write the importStepsFromString() method we can more fully test that and catch things like this 😄

[jywarren]

The quickest fix right now should just be to switch to , separation, i think? We can do the other default-sensitive stuff as a follow-up.

[jywarren]

To preserve this usage: https://publiclab.org/notes/warren/05-30-2018/use-image-sequencer-for-ndvi-plant-analysis-with-2-images

[tech4GT]

@jywarren I am getting an error loading the monarch image but this is working fine!!

[jywarren]

really? did you not see the error I saw?

[jywarren]

I think we need to change this line:

image-sequencer/src/ImageSequencer.js

Line 226 in 871453b

let steps = str.split('),');

[jywarren]

I can do it if it's too late at night?

[tech4GT]

@jywarren I think this is working fine but the image is not being loaded

[jywarren]

Are you sure you're in the right branch? On the link that I shared at top, it doesn't even load the steps.

[tech4GT]

@jywarren got the problem!!

[tech4GT]

https://publiclab.github.io/image-sequencer/examples/#steps=import-image(url:https%3A%2F%2Fpubliclab.github.io%2Fimage-sequencer%2Fexamples%2Fimages%2Fmonarch.png),blend(blend:function(r1%2C%20g1%2C%20b1%2C%20a1%2C%20r2%2C%20g2%2C%20b2%2C%20a2)%20%7B%20return%20%5B%20r1%2C%20g2%2C%20b2%2C%20a2%20%5D%20%7D),ndvi(filter:red),colormap(colormap:fastie)

Hit this url and for now please enter the path https://publiclab.github.io/image-sequencer/examples/images/monarch.png in import image

[jywarren]

I wrote a test for this -- see #279

[tech4GT]

and click save, it should work

[jywarren]

I don't believe the monarch.png issue is blocking, although we should separately solve it -- it doesn't stop https://publiclab.github.io/image-sequencer/examples/#steps=import-image,blend,ndvi,colormap from running though!

[tech4GT]

@jywarren the () are essential!!

[tech4GT]

please use them after every step they are essential!!

[jywarren]

Fixed in #279 ! Thanks Varun!

[jywarren]

Part of the solution was to substitute | pipe characters for the commas when inside of the step settings, so:

#steps=invert,crop(x:1|y:0|h:10|w:10)