Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module not found error on demo #537

Closed
jywarren opened this issue Dec 8, 2018 · 7 comments
Closed

Module not found error on demo #537

jywarren opened this issue Dec 8, 2018 · 7 comments
Labels
bug HTML module New Module idea

Comments

@jywarren
Copy link
Member

jywarren commented Dec 8, 2018

I tried to load the ndvi module with:

http://sequencer.publiclab.org/examples/#steps=nvdi,colormap

But I got this error:

Module nvdi not found.
image-sequencer.js:58267 Uncaught TypeError: Cannot read property 'description' of undefined
    at insertStep (image-sequencer.js:58267)
    at InsertStep (image-sequencer.js:58303)
    at AddStep (image-sequencer.js:57534)
    at Object.addSteps (image-sequencer.js:57857)
    at eachStep (image-sequencer.js:58114)
    at Array.forEach (<anonymous>)
    at Object.importString (image-sequencer.js:58113)
    at importStepsFromUrlHash (defaultHtmlSequencerUi.js:20)
    at Object.onLoad (defaultHtmlSequencerUi.js:9)
    at load (image-sequencer.js:57967)
insertStep @ image-sequencer.js:58267
InsertStep @ image-sequencer.js:58303
AddStep @ image-sequencer.js:57534
addSteps @ image-sequencer.js:57857
eachStep @ image-sequencer.js:58114
importString @ image-sequencer.js:58113
importStepsFromUrlHash @ defaultHtmlSequencerUi.js:20
onLoad @ defaultHtmlSequencerUi.js:9
load @ image-sequencer.js:57967
(anonymous) @ image-sequencer.js:57972
(anonymous) @ image-sequencer.js:61437
CImage.image.onload @ image-sequencer.js:61377
load (async)
CImage @ image-sequencer.js:61372
loadImage @ image-sequencer.js:61427
LoadImage @ image-sequencer.js:61442
load @ image-sequencer.js:57971
loadImages @ image-sequencer.js:57976
window.onload @ demo.js:32
load (async)
(anonymous) @ demo.js:1
@gitmate gitmate bot added HTML module New Module idea labels Dec 8, 2018
@jywarren
Copy link
Member Author

jywarren commented Dec 8, 2018

We should ensure all modules pass tests!

@gitmate
Copy link

gitmate bot commented Dec 8, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #278 (Module not found error in demo), #145 ("reader is not defined" error on demo), #3 (CORS Image error on GitHub hosted demos), #290 (drag/drop error on 1st step of demo), and #142 (Add select dropdown for some module UIs in demo).

1 similar comment
@gitmate
Copy link

gitmate bot commented Dec 8, 2018

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #278 (Module not found error in demo), #145 ("reader is not defined" error on demo), #3 (CORS Image error on GitHub hosted demos), #290 (drag/drop error on 1st step of demo), and #142 (Add select dropdown for some module UIs in demo).

@gitmate gitmate bot removed the help wanted label Dec 8, 2018
@tech4GT
Copy link
Member

tech4GT commented Dec 9, 2018

I'll look into this @jywarren

@tech4GT
Copy link
Member

tech4GT commented Dec 9, 2018

Hmm, maybe some tests were modified in previous pull requests, I'll make sure test are fine too! Also I was thinking of setting up LGTM, what say?

@tech4GT
Copy link
Member

tech4GT commented Dec 9, 2018

Update: @jywarren Actually ndvi is not spelled correctly in the link, it says nvdi and not ndvi
lol haha

@tech4GT tech4GT closed this as completed Dec 9, 2018
@jywarren
Copy link
Member Author

LOL omg that's a relief! Let's NOT add a spellcheck to the codebase though 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug HTML module New Module idea
Projects
None yet
Development

No branches or pull requests

2 participants