Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configurable parameters for blend module image number #421

Closed
jywarren opened this issue Oct 18, 2018 · 10 comments
Closed

configurable parameters for blend module image number #421

jywarren opened this issue Oct 18, 2018 · 10 comments
Labels

Comments

@jywarren
Copy link
Member

I believe the blend image module, which combines two previous step's outputs, has a fixed or static choice of which two images to use. We should make the default be what it currently is, but allow a settable option parameter for which earlier step to blend in, as an integer index. So two steps back would be -2, three would be -3.

This shouldn't be too hard to make into a first-timers-only issue!

@gitmate gitmate bot added first-timers-only module New Module idea labels Oct 18, 2018
@gitmate
Copy link

gitmate bot commented Oct 18, 2018

GitMate.io thinks possibly related issues are #5 (image cropping module), #116 (Image overlay module), #162 (Modify the test to check number of modules), #233 (Add an "import image" module), and #108 (Math Module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Oct 18, 2018

GitMate.io thinks possibly related issues are #5 (image cropping module), #116 (Image overlay module), #162 (Modify the test to check number of modules), #233 (Add an "import image" module), and #108 (Math Module).

@ssaini24
Copy link

Can i take this issue?

@tech4GT
Copy link
Member

tech4GT commented Oct 18, 2018

Sure @vagita24!! Go ahead!

@JKusio
Copy link

JKusio commented Oct 18, 2018

I didn't see the vagita24 comment, and I've made my solution for this issue.

@tech4GT
Copy link
Member

tech4GT commented Oct 18, 2018

Oh! Hmm, @kusioDev please do claim the issue before working on it. It saves a lot of effort. Anyway since you have already opened a project, @vagita24 we can really use your help on another one. Thanks!😄

@JKusio
Copy link

JKusio commented Oct 18, 2018

Sorry, I'm new to this, and I'm still learning. Next time I'll claim the issue so others won't waste their time 😁

@tech4GT
Copy link
Member

tech4GT commented Oct 18, 2018

Thanks a lot @KusioDev It's okay, don't stress on it. Thanks for your contribution 😄

@aashna27
Copy link

aashna27 commented Jan 4, 2019

i believe this issue has been resolve .

@grvsachdeva
Copy link
Member

Yes, it's solved in #424. Closing now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants