Overlay module offset parameter doesn't work

[jywarren]

The Overlay module has a parameter called "offset" which lets you set which step is overlaid onto. But it doesn't seem to work:

See it malfunctioning here in the final step:

http://sequencer.publiclab.org/examples/#steps=crop{x:0|y:0|w:611|h:479},gradient{},colormap{colormap:stretched},crop{x:0|y:0|w:611|h:60},resize{resize:25%25},overlay{x:5|y:5|offset:-5}

Compare to:

http://sequencer.publiclab.org/examples/#steps=crop{x:0|y:0|w:611|h:479},gradient{},colormap{colormap:stretched},crop{x:0|y:0|w:611|h:60},resize{resize:25%25},overlay{x:5|y:5|offset:-3}

It always seems to source the same image!

The code for the Overlay module is here: https://github.com/publiclab/image-sequencer/tree/master/src/modules/Overlay

[jywarren]

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

[gitmate]

GitMate.io thinks possibly related issues are #213 (Crop Module not working correctly), #116 (Image overlay module), #430 (Colorbar overlay module with more advanced design), #421 (configurable parameters for blend module image number), and #188 (Add a list of working modules and their parameters in the documentation).

[gitmate]

GitMate.io thinks possibly related issues are #213 (Crop Module not working correctly), #116 (Image overlay module), #430 (Colorbar overlay module with more advanced design), #421 (configurable parameters for blend module image number), and #188 (Add a list of working modules and their parameters in the documentation).

[keshav234156]

@jywarren made some cahnges.

Is this the expexted behaviour?

[jywarren]

Yes! It is! Wow, great work! Do you have a PR open for this? Thank you!

[keshav234156]

@jywarren it's also working fine with the beta version.I think that this issue has been fixed with #1082 .
So we could now close this issue

[keshav234156]

@jywarren @harshkhandeparkar can you please close this issue as it's already fixed in #1082 and is working as expected in beta version .