Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weird border on right and bottom of thumbnail grid #615

Closed
bhavayAnand9 opened this issue Jan 6, 2019 · 11 comments
Closed

weird border on right and bottom of thumbnail grid #615

bhavayAnand9 opened this issue Jan 6, 2019 · 11 comments

Comments

@bhavayAnand9
Copy link
Member

Please describe the problem (or idea)

screenshot 2019-01-06 at 14 45 52

there's an excessive space on right and bottom of thumbnail grid.

It should be like this

screenshot 2019-01-06 at 14 46 30

fix:
I think it's because of overflow:scroll property on radio-group class, changing it with auto fixes the issue.

Please show us where to look

http://sequencer.publiclab.org...

Browser, version, and operating system

Chrome, Macos


Thank you!

@bhavayAnand9
Copy link
Member Author

@tech4GT can you confirm this and maybe add the first-timer-only tag?

@gitmate
Copy link

gitmate bot commented Jan 6, 2019

GitMate.io thinks possibly related issues are #260 (Blur module producing a black 'border' at the top and bottom), and #247 (grid of thumbnails showing step options in addStep ui).

1 similar comment
@gitmate
Copy link

gitmate bot commented Jan 6, 2019

GitMate.io thinks possibly related issues are #260 (Blur module producing a black 'border' at the top and bottom), and #247 (grid of thumbnails showing step options in addStep ui).

@harshkhandeparkar
Copy link
Member

I've had the same issue. Its because of the overflow:scroll property which was added recently. Its just the scrollbar.

@harshkhandeparkar
Copy link
Member

Possible fix would be to add overflow:scroll only on small screen sizes.

@harshkhandeparkar
Copy link
Member

No problems on my phone though

screenshot_20190106-151548

Desktop view:

screenshot_20190106-151533

@bhavayAnand9
Copy link
Member Author

Possible fix would be to add overflow:scroll only on small screen sizes.

setting overflow to auto does the same. It only adds scrollbar when necessary unlike scroll which adds it even if we don't need it.

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 6, 2019 via email

@bhavayAnand9
Copy link
Member Author

It's better to leave it for first-timers.

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Jan 6, 2019 via email

@harshkhandeparkar
Copy link
Member

@VibhorCodecianGupta this is linked to your PR. Do you want to fix this? It is very annoying. It is a very small fix too. Maybe its too simple for being an fto-candidate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants