Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image upload in Firefox(Mac) and bugs in image effects module selecting via addStep #7

Closed
rackstar17 opened this issue Mar 9, 2017 · 5 comments
Closed

Image upload in Firefox(Mac) and bugs in image effects module selecting via addStep #7

rackstar17 opened this issue Mar 9, 2017 · 5 comments

Comments

@rackstar17
Copy link

  1. When I upload an image in Firefox (Mac) Image does not upload and I get this issue in the console

image-upload

  1. No module works when I select it from the select dropdown and then click on add step , I get the following issue on the console

green-channel-issue

I tested it in dev mode, not on the github hosted versions
@ccpandhare
Copy link
Collaborator

ccpandhare commented Mar 11, 2017 •
edited
Loading

I have fixed the ReferenceError issue in my PR.
It hasn't been merged yet See Issue #2 , PR #6

@rackstar17
Copy link
Author

PR #6 does not fix the problems mentioned above
Uncaught error still shows up when image is uploaded not dragged

ccpandhare added a commit to ccpandhare/image-sequencer that referenced this issue Mar 12, 2017
@ccpandhare
Small fix for FireFox; Ref: Issue publiclab#7
633f1f3
@ccpandhare
Copy link
Collaborator

ccpandhare commented Mar 12, 2017 •
edited
Loading

Yeah I saw that. Sorry I hadn't tested that on Firefox for Mac.
I've fixed that in PR #12

@jywarren
Copy link
Member

jywarren commented Mar 12, 2017 via email

jywarren pushed a commit that referenced this issue Mar 14, 2017
@ccpandhare @jywarren
Fix for Issue9 : Error while adding a new step from HTML UI, A small …
38a569b 
…fix for #7 (#16)

* Fix : add a step in the demo

* Change global variable to document.sequencer_image

* Change global variable to document.sequencer_image

* Small fix for FireFox; Ref: Issue #7

* Change document.sequencer_image to options.image

* Change document.sequencer_image to options.initial_image

* Completed the addStep issue.

* Completed the addStep issue.

* Change options.initial_image to options.initialImage

* Added Crop Module

* lowercase parameters

* Merging Crop.js

* Merging Crop.js

* Merging Crop.js
@ccpandhare
Copy link
Collaborator

I think this issue isn't needed anymore.

@ccpandhare ccpandhare assigned ccpandhare and unassigned ccpandhare Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jywarren @rackstar17 @ccpandhare