Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag to select crop UI is broken #987

Closed
jywarren opened this issue Apr 4, 2019 · 1 comment · Fixed by #1019
Closed

Drag to select crop UI is broken #987

jywarren opened this issue Apr 4, 2019 · 1 comment · Fixed by #1019

Comments

@jywarren
Copy link
Member

jywarren commented Apr 4, 2019

#205 added this nice interface for cropping -- drag selection -- and #229 was supposed to build on this. However it seems broken now --

image

Looks like we're running imgAreaSelect on imgEl here:

// step.imgSelector is not defined, imgElement is:
function imgEl() {
return step.imgElement;
}

But sequencer.steps[1].imgElement doesn't return anything anymore. It's supposed to be set here:

step.imgElement = step.ui.querySelector("a img.img-thumbnail");

And $("a img.img-thumbnail"); still returns elements, so that /should/ work...

Did I break it here?

https://github.com/publiclab/image-sequencer/pull/960/files#diff-8fab943ef984aa24b7a63cbe4442daeaR71

Would love help fixing this! Then we should write a UI test for it -- send a click event to the image, and ensure that a selection box appears.

@vibhorgupta-gh
Copy link

Looking into this and other relevant crop module issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants