We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#205 added this nice interface for cropping -- drag selection -- and #229 was supposed to build on this. However it seems broken now --
Looks like we're running imgAreaSelect on imgEl here:
imgAreaSelect
imgEl
image-sequencer/src/modules/Crop/Ui.js
Lines 74 to 77 in 0e7323e
But sequencer.steps[1].imgElement doesn't return anything anymore. It's supposed to be set here:
sequencer.steps[1].imgElement
image-sequencer/examples/lib/defaultHtmlStepUi.js
Line 71 in 985c678
And $("a img.img-thumbnail"); still returns elements, so that /should/ work...
$("a img.img-thumbnail");
Did I break it here?
https://github.com/publiclab/image-sequencer/pull/960/files#diff-8fab943ef984aa24b7a63cbe4442daeaR71
Would love help fixing this! Then we should write a UI test for it -- send a click event to the image, and ensure that a selection box appears.
The text was updated successfully, but these errors were encountered:
Looking into this and other relevant crop module issues.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
#205 added this nice interface for cropping -- drag selection -- and #229 was supposed to build on this. However it seems broken now --
Looks like we're running
imgAreaSelect
onimgEl
here:image-sequencer/src/modules/Crop/Ui.js
Lines 74 to 77 in 0e7323e
But
sequencer.steps[1].imgElement
doesn't return anything anymore. It's supposed to be set here:image-sequencer/examples/lib/defaultHtmlStepUi.js
Line 71 in 985c678
And
$("a img.img-thumbnail");
still returns elements, so that /should/ work...Did I break it here?
https://github.com/publiclab/image-sequencer/pull/960/files#diff-8fab943ef984aa24b7a63cbe4442daeaR71
Would love help fixing this! Then we should write a UI test for it -- send a click event to the image, and ensure that a selection box appears.
The text was updated successfully, but these errors were encountered: