Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "drag to crop" UI feature to Crop module #205

Closed
jywarren opened this issue Mar 22, 2018 · 6 comments
Closed

add "drag to crop" UI feature to Crop module #205

jywarren opened this issue Mar 22, 2018 · 6 comments

Comments

@jywarren
Copy link
Member

I was thinking that the ability to drag a region to be cropped using the Crop tool would be great, when using the default HTML UI. It might take a couple hundred lines of code, however, and I'm not sure we'd want that in the core library. Is this an example of something we should develop as a separate module entirely?

@jywarren
Copy link
Member Author

GitMate.io thinks the contributor most likely able to help you is @ccpandhare.

Possibly related issues are #5 (image cropping module), #158 (Add a Saturation Module), #157 (Add a Contrast module), #27 (add fisheyegl module), and #113 (Add a Brightness module).

@tech4GT
Copy link
Member

tech4GT commented Mar 22, 2018

@jywarren we can use a jQuery plugin for that, that would keep it separated from our core code
please have a look at this http://odyniec.net/projects/imgareaselect/

@jywarren
Copy link
Member Author

jywarren commented Mar 22, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Apr 10, 2018

@jywarren this one is almost done, will be submitting pr by tomorrow
Thanks😁

@jywarren
Copy link
Member Author

jywarren commented Apr 10, 2018 via email

tech4GT added a commit to tech4GT/image-sequencer that referenced this issue Apr 18, 2018
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
tech4GT added a commit to tech4GT/image-sequencer that referenced this issue Apr 18, 2018
@jywarren
Copy link
Member Author

jywarren commented May 4, 2018

Complete in #245!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants