Threshold module, not working yet #123

jywarren · 2017-09-23T17:54:30Z

Hi, @ccpandhare -- just going through the steps here to add a module again -- re-adding the thresholding module -- and ran into some trouble. I see the error:

Uncaught TypeError: Cannot read property 'src' of undefined
    at drawStep (image-sequencer.js:39450)
    at image-sequencer.js:39459
    at Image.onLoad (image-sequencer.js:40267)

Any idea what I'm missing here? This is also a good "shakedown test" possibly related to #122 before we announce this more widely and completely standardize the module format. Thanks!

jywarren · 2017-09-23T18:33:31Z

Ooh, yikes. This is all messed up; i was pretty sure i was working from master but it looks like i was working from gh-pages... i'll fix this.

jywarren · 2017-09-23T18:37:37Z

There, rebased and cleaned it up.

ccpandhare · 2017-09-24T06:27:29Z

src/modules/Threshold/Module.js

@@ -25,7 +31,13 @@ module.exports = function ImageThreshold(options) {
    }).then(function (imageData) {
      image = new Image();
      image.onload = function onLoad() {
-        if (options.output) options.output(image);
+        this.output = {


this is being used in the wrong context; The output needs to be set for the "step" object. Like this:

function draw (inputImage) { var step = this; ... ... ... image = new Image(); image.onload = function onLoad() { step.output = { format: input.type, src: image.src } options.step.output = step.output.src; callback(); UI.onComplete(options.step); }

Ah, let's refactor existing modules to save this into var step to avoid this ambiguity.

Ah, i see that existing modules are already this way! Great, it must just be that the Threshold module wasn't.

ccpandhare · 2017-09-24T06:29:34Z

src/modules/Threshold/Module.js

-    canvas.width = inputImage.naturalWidth;
-    canvas.height = inputImage.naturalHeight;
+    canvas.width = image.naturalWidth;
+    canvas.height = image.naturalHeight;


This will work only on browsers, right? I think it's pretty easy to write a threshold module - we could as well do it without using the native Image and Canvas classes.

ccpandhare

I think this can be done without the native Image and Canvas classes to ensure Node.js support.

The issue was that the output of the step was not being set as a property of "step"; A problem of scope. I think this brings more focus on #122. It sure is really confusing to create a module. I shall look into it.

jywarren · 2017-09-25T22:51:48Z

OK -- i mean, we can achieve this using PixelManipulation, for example. Shall I refactor for that?

Also - we should have a section in Contributing Modules that talks about Node/Browser compatibility with this in mind, so it's more clear to people, and we can also link to that section when people submit modules like this. We can have some possible solutions in that section too. Adding this suggestion to #122.

ccpandhare · 2017-09-27T02:47:05Z

Yes I think that's an awesome idea!! It'll make contributing clearer; yes, pixel manipulation can do that :-)

…

On Tue, Sep 26, 2017, 04:21 Jeffrey Warren ***@***.***> wrote: OK -- i mean, we can achieve this using PixelManipulation, for example. Shall I refactor for that? Also - we should have a section in Contributing Modules that talks about Node/Browser compatibility with this in mind, so it's more clear to people, and we can also link to that section when people submit modules like this. We can have some possible solutions in that section too. Adding this suggestion to #122 <#122>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT0xnMj2tvQFJsuSmYO5DVls--zjX9mvks5smC6EgaJpZM4PhoQ0> .

ccpandhare · 2017-10-13T10:25:29Z

Will it be okay for me to do this?

jywarren · 2017-10-13T12:41:26Z

Sure, yes please!

…

On Oct 13, 2017 6:25 AM, "Chinmay Pandhare" ***@***.***> wrote: Will it be okay for me to do this? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ1gm2a2aTbp9sFwpDaUwhDIrlUD9ks5srzqZgaJpZM4PhoQ0> .

ccpandhare · 2017-10-18T05:32:30Z

Introduction

Have been doing some research on this and I came across the following :

I wanted to have a look at the algorithm so as to make a node-and-browser compatible version.

I think there is much more to thresholding than we had currently implemented.

There's Full RGB Quantization, Plane-by-plane RGB Quantization, etc.

Notes

Single Channel Thresholding

When there is only one channel, per pixel the channel value is made into max or min based on whether it is above a certain threshold value.

Multiple Channel (Color Input, Color Output) Thresholding

When there are multiple channels,

The above can be done per channel. (Plane by Plane RGB Quantization)
OTSU's Method can be used. (Full RGB Quantization)

Multiple Channels (Color Input, Black/White Output) Thresholding

Method 1 : Separate thresholds for R,G,B,A and then AND them
Method 2 : Convert to HSLA and then do the above

Method 1 above segments the image as per how the camera stores it, but not how a human would view it. Method 2 is how a human brain would analyze the image.

Further Steps

So what do you think we should do, @jywarren ? All of these, some of these?

jywarren · 2017-10-18T13:18:40Z

Let's start with just one, perhaps the easiest one, and we can leave these great docs for the next person who wants to take the next step. Sound good?

…

On Oct 18, 2017 1:32 AM, "Chinmay Pandhare" ***@***.***> wrote: Introduction Have been doing some research on this and I came across the following : - https://in.mathworks.com/help/images/ref/multithresh.html - http://ieeexplore.ieee.org/document/5445591/ - https://en.wikipedia.org/wiki/Thresholding_(image_processing) I wanted to have a look at the algorithm so as to make a node-and-browser compatible version. I think there is much more to thresholding than we had currently implemented. There's Full RGB Quantization, Plane-by-plane RGB Quantization, etc. Notes Single Channel Thresholding When there is only one channel, per pixel the channel value is made into max or min based on whether it is above a certain threshold value. Multiple Channel (Color Input, Color Output) Thresholding When there are multiple channels, - The above can be done per channel. (Plane by Plane RGB Quantization) - OTSU's Method can be used. (Full RGB Quantization) Multiple Channels (Color Input, Black/White Output) Thresholding - Method 1 : Separate thresholds for R,G,B,A and then AND them - Method 2 : Convert to HSLA and then do the above Method 1 above segments the image as per how the camera stores it, but not how a human would view it. Method 2 is how a human brain would analyze the image. Further Steps So what do you think we should do, @jywarren <https://github.com/jywarren> ? All of these, some of these? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7l9ApddXP2UnkRvsIyfVX63fg2Hks5stY1ugaJpZM4PhoQ0> .

ccpandhare · 2017-10-18T20:28:48Z

Sounds good. I'll try to implement the HSLA B/W one then.

…

On Wed, Oct 18, 2017, 18:48 Jeffrey Warren ***@***.***> wrote: Let's start with just one, perhaps the easiest one, and we can leave these great docs for the next person who wants to take the next step. Sound good? On Oct 18, 2017 1:32 AM, "Chinmay Pandhare" ***@***.***> wrote: > Introduction > > Have been doing some research on this and I came across the following : > > - https://in.mathworks.com/help/images/ref/multithresh.html > - http://ieeexplore.ieee.org/document/5445591/ > - https://en.wikipedia.org/wiki/Thresholding_(image_processing) > > I wanted to have a look at the algorithm so as to make a node-and-browser > compatible version. > > I think there is much more to thresholding than we had currently > implemented. > > There's Full RGB Quantization, Plane-by-plane RGB Quantization, etc. > Notes Single Channel Thresholding > > When there is only one channel, per pixel the channel value is made into > max or min based on whether it is above a certain threshold value. > Multiple Channel (Color Input, Color Output) Thresholding > > When there are multiple channels, > > - The above can be done per channel. (Plane by Plane RGB Quantization) > - OTSU's Method can be used. (Full RGB Quantization) > > Multiple Channels (Color Input, Black/White Output) Thresholding > > - Method 1 : Separate thresholds for R,G,B,A and then AND them > - Method 2 : Convert to HSLA and then do the above > > Method 1 above segments the image as per how the camera stores it, but not > how a human would view it. Method 2 is how a human brain would analyze the > image. > Further Steps > > So what do you think we should do, @jywarren < https://github.com/jywarren> > ? All of these, some of these? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > < #123 (comment) >, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AABfJ7l9ApddXP2UnkRvsIyfVX63fg2Hks5stY1ugaJpZM4PhoQ0 > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#123 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT0xnD15iAYbtdhfTxgIdjHE0vGEzj0rks5stfqxgaJpZM4PhoQ0> .

grvsachdeva · 2019-01-04T21:41:30Z

@jywarren @tech4GT

harshkhandeparkar · 2019-03-03T18:33:55Z

Threshold module added already in #722.

re-adding threshold module, not finished

3e608e2

jywarren force-pushed the threshold-module branch from 4e86708 to 3e608e2 Compare September 23, 2017 18:37

ccpandhare reviewed Sep 24, 2017

View reviewed changes

ccpandhare requested changes Sep 24, 2017

View reviewed changes

jywarren mentioned this pull request Sep 25, 2017

Simplify and minimize module requirements #122

Closed

5 tasks

jywarren mentioned this pull request Jan 24, 2019

New Module Ideas For Image Sequencer #694

Open

aashna27 mentioned this pull request Jan 27, 2019

Added Threshold #722

Merged

4 tasks

harshkhandeparkar closed this Mar 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Threshold module, not working yet #123

Threshold module, not working yet #123

jywarren commented Sep 23, 2017

jywarren commented Sep 23, 2017

jywarren commented Sep 23, 2017

ccpandhare Sep 24, 2017

jywarren Oct 5, 2017

jywarren Oct 5, 2017

ccpandhare Sep 24, 2017

ccpandhare left a comment

jywarren commented Sep 25, 2017

ccpandhare commented Sep 27, 2017 via email

ccpandhare commented Oct 13, 2017

jywarren commented Oct 13, 2017 via email

ccpandhare commented Oct 18, 2017

jywarren commented Oct 18, 2017 via email

ccpandhare commented Oct 18, 2017 via email

grvsachdeva commented Jan 4, 2019

harshkhandeparkar commented Mar 3, 2019 •

edited

Loading

Threshold module, not working yet #123

Threshold module, not working yet #123

Conversation

jywarren commented Sep 23, 2017

jywarren commented Sep 23, 2017

jywarren commented Sep 23, 2017

ccpandhare Sep 24, 2017

Choose a reason for hiding this comment

jywarren Oct 5, 2017

Choose a reason for hiding this comment

jywarren Oct 5, 2017

Choose a reason for hiding this comment

ccpandhare Sep 24, 2017

Choose a reason for hiding this comment

ccpandhare left a comment

Choose a reason for hiding this comment

jywarren commented Sep 25, 2017

ccpandhare commented Sep 27, 2017 via email

ccpandhare commented Oct 13, 2017

jywarren commented Oct 13, 2017 via email

ccpandhare commented Oct 18, 2017

Introduction

Notes

Single Channel Thresholding

Multiple Channel (Color Input, Color Output) Thresholding

Multiple Channels (Color Input, Black/White Output) Thresholding

Further Steps

jywarren commented Oct 18, 2017 via email

ccpandhare commented Oct 18, 2017 via email

grvsachdeva commented Jan 4, 2019

harshkhandeparkar commented Mar 3, 2019 • edited Loading

harshkhandeparkar commented Mar 3, 2019 •

edited

Loading