Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dimension upon loading through camera #1456

Merged
merged 10 commits into from
Oct 16, 2020

Conversation

ataata107
Copy link

Concerns #1391
In PR #1395 Only the case of loading image was taken care of not the loading through camera. This PR fixes that

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@ataata107
Copy link
Author

@publiclab/is-reviewers

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #1456 into main will increase coverage by 10.31%.
The diff coverage is 64.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1456       +/-   ##
===========================================
+ Coverage   55.11%   65.43%   +10.31%     
===========================================
  Files         117      133       +16     
  Lines        2344     2743      +399     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 102 more

@ataata107
Copy link
Author

@harshkhandeparkar do i need to refactor in order to fix the codeclimate issue

@harshkhandeparkar
Copy link
Member

Nah. Let it be.

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020

@harshkhandeparkar harshkhandeparkar requested a review from a team as a code owner October 15, 2020 19:49
@jywarren
Copy link
Member

Great, thanks!!!!

@jywarren jywarren merged commit f4baebd into publiclab:main Oct 16, 2020
@jywarren
Copy link
Member

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants