-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show histogram values #1458
base: main
Are you sure you want to change the base?
Show histogram values #1458
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1458 +/- ##
===========================================
+ Coverage 55.11% 65.41% +10.29%
===========================================
Files 117 132 +15
Lines 2344 2741 +397
Branches 360 438 +78
===========================================
+ Hits 1292 1793 +501
+ Misses 1052 948 -104
|
@publiclab/is-reviewers |
Woah. Why was extra manipulation called before changePixel? |
Is it not the case with other modules? |
It should not be. If it is then it is a serious issue, |
Is it? |
Sorry for the late reply. |
Yeah there is a need to open an issue. Do you want to do this or should I do it? |
Go Ahead |
Fixes #1457 (<=== Replace
0000
with the Issue Number)So apparently extraManipulation was being called before than changePixel hence the changes were required
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!