Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show histogram values #1458

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Show histogram values #1458

wants to merge 3 commits into from

Conversation

ataata107
Copy link

@ataata107 ataata107 commented Jan 11, 2020

Fixes #1457 (<=== Replace 0000 with the Issue Number)

So apparently extraManipulation was being called before than changePixel hence the changes were required
ezgif com-video-to-gif (6)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 11, 2020

Codecov Report

Merging #1458 into main will increase coverage by 10.29%.
The diff coverage is 64.11%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1458       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2741      +397     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) ⬇️
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) ⬇️
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) ⬆️
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) ⬇️
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

@ataata107
Copy link
Author

@publiclab/is-reviewers

@harshkhandeparkar
Copy link
Member

Woah. Why was extra manipulation called before changePixel?

@ataata107
Copy link
Author

Is it not the case with other modules?

@harshkhandeparkar
Copy link
Member

It should not be. If it is then it is a serious issue,

@harshkhandeparkar
Copy link
Member

Is it?

@ataata107
Copy link
Author

Sorry for the late reply.
Yes I think it is . Is there a need to open an issue for the same.

@harshkhandeparkar
Copy link
Member

Yeah there is a need to open an issue. Do you want to do this or should I do it?

@ataata107
Copy link
Author

Go Ahead

@gitpod-io
Copy link

gitpod-io bot commented Jul 8, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Histogram Module is failing
2 participants