-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed paint bucket fill color error #1519
Conversation
Thanks for opening this pull request! |
Codecov Report
@@ Coverage Diff @@
## main #1519 +/- ##
=========================================
+ Coverage 66.64% 66.8% +0.16%
=========================================
Files 129 129
Lines 2662 2672 +10
Branches 428 430 +2
=========================================
+ Hits 1774 1785 +11
+ Misses 888 887 -1
|
@Olusamimaths please write issue number here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please multiply the alpha by 255
and not 256
.
@Olusamimaths please add the issue number, and also change the multiplier value to |
Corrected the multiplier from 256 to 255
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats on merging your first pull request! 🙌🎉⚡️ |
Great work, thanks, folks! |
Fixes #1488
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!