Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ExtraManipulation #1551

Merged
merged 4 commits into from
Jan 21, 2020
Merged

Conversation

rishabhshuklax
Copy link
Member

Fixes #1547

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below
  • Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@dc1647e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1551   +/-   ##
=======================================
  Coverage        ?   66.64%           
=======================================
  Files           ?      130           
  Lines           ?     2674           
  Branches        ?      430           
=======================================
  Hits            ?     1782           
  Misses          ?      892           
  Partials        ?        0

@root00198
Copy link
Member

It looks good though..

@jywarren
Copy link
Member

Hmm @blurry-x-face @root00198 this is oddly taking a long time...?

@root00198
Copy link
Member

I think you can restart the build...

@jywarren
Copy link
Member

Going to try restarting it.

@jywarren
Copy link
Member

OK Awesome! I'll merge this, can you warn some other PR folks to rebase theirs? Thank you!

@jywarren jywarren merged commit 8b18d2d into publiclab:main Jan 21, 2020
@rishabhshuklax rishabhshuklax mentioned this pull request Jan 22, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem in extraManipulation
3 participants