Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #131 create output directory immediately #167

Merged
merged 4 commits into from
Feb 6, 2018

Conversation

tech4GT
Copy link
Member

@tech4GT tech4GT commented Feb 5, 2018

Signed-off-by: tech4GT varun.gupta1798@gmail.com

Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
@tech4GT
Copy link
Member Author

tech4GT commented Feb 5, 2018

@jywarren please have a look😁

@jywarren
Copy link
Member

jywarren commented Feb 5, 2018

Awesome! Do you think it would be tough to add a test for this? I guess we don't have CLI tests... what do you think?

@tech4GT
Copy link
Member Author

tech4GT commented Feb 5, 2018

@jywarren Not at all. Adding a test for this right away😁

@tech4GT
Copy link
Member Author

tech4GT commented Feb 5, 2018

@jywarren should i create a separate issue for adding cli tests so we can add tests for other stuff like validate steps as well, what say?

@tech4GT
Copy link
Member Author

tech4GT commented Feb 5, 2018

@jywarren actually for creating this output directory all we have done is just call a native nodejs file system function so for adding a test for this i would have to wrap this up in a function but since it is only one line it will introduce unnecessary complexity, should i do it?

Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
@jywarren
Copy link
Member

jywarren commented Feb 5, 2018

Actually i think making a createDirectory function independently is probably a good idea, no? Clearly marked as running on the CLI/node only? What do you think?

@tech4GT
Copy link
Member Author

tech4GT commented Feb 6, 2018

@jywarren it's done please have a look, also i found a small error that if we do not give any steps to cli it does not exit cleanly, so i also fixed that in this commit. Thanks

@jywarren
Copy link
Member

jywarren commented Feb 6, 2018

Awesome, thanks so much!!! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants