-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #131 create output directory immediately #167
Conversation
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
@jywarren please have a look😁 |
Awesome! Do you think it would be tough to add a test for this? I guess we don't have CLI tests... what do you think? |
@jywarren Not at all. Adding a test for this right away😁 |
@jywarren should i create a separate issue for adding cli tests so we can add tests for other stuff like validate steps as well, what say? |
@jywarren actually for creating this output directory all we have done is just call a native nodejs file system function so for adding a test for this i would have to wrap this up in a function but since it is only one line it will introduce unnecessary complexity, should i do it? |
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Actually i think making a |
@jywarren it's done please have a look, also i found a small error that if we do not give any steps to cli it does not exit cleanly, so i also fixed that in this commit. Thanks |
Awesome, thanks so much!!! 🎉 |
Signed-off-by: tech4GT varun.gupta1798@gmail.com