-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added how to run the debug script #192
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, great work😁👍
Also i recommend please always make changes after making a new branch, that way your master branch remains in sync with ours, otherwise good work
Thanks👍
@jywarren this looks good, can be merged👍 |
Thanks:) |
This is great. @tech4GT if you want to do a "review" and "approve" PRs, or even mark them |
Yep! Thanks!
…On Mon, Feb 26, 2018 at 10:56 AM, Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> by marking ready you mean
approving and commenting 'ready to be merged' right? I apologise i didn't
understand exactly😅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#192 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5IQ7nSDDUVcIlM4gx3ttGNv2YeEks5tYtQegaJpZM4SSMYg>
.
|
@jywarren no prob, always happy to help😁 |
@jywarren Oh i get it you were talking about adding a label to it😅 |
oh really? Oops, sorry! I thought it was enough to add you to the reviewers group but i see that's not quite it. I added you as a collaborator -- now see? |
@jywarren thanks a ton, now it's working, I'll be labelling prs with ready-to-merge from now on😁 |
No description provided.