Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added how to run the debug script #192

Merged
merged 1 commit into from
Feb 26, 2018
Merged

Added how to run the debug script #192

merged 1 commit into from
Feb 26, 2018

Conversation

gayathriravipati
Copy link

No description provided.

Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, great work😁👍
Also i recommend please always make changes after making a new branch, that way your master branch remains in sync with ours, otherwise good work
Thanks👍

@tech4GT
Copy link
Member

tech4GT commented Feb 25, 2018

@jywarren this looks good, can be merged👍

@gayathriravipati
Copy link
Author

Thanks:)
I will create a new branch from next time.

@jywarren
Copy link
Member

This is great. @tech4GT if you want to do a "review" and "approve" PRs, or even mark them ready i can merge these in a bit faster. Thanks a million to both of you, this is great.

@jywarren jywarren merged commit 973ec6d into publiclab:master Feb 26, 2018
@jywarren
Copy link
Member

jywarren commented Feb 26, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Feb 26, 2018

@jywarren no prob, always happy to help😁

@tech4GT
Copy link
Member

tech4GT commented Feb 26, 2018

@jywarren Oh i get it you were talking about adding a label to it😅
Actually I don't have the rights to label issues and prs yet...

@jywarren
Copy link
Member

oh really? Oops, sorry! I thought it was enough to add you to the reviewers group but i see that's not quite it. I added you as a collaborator -- now see?

@tech4GT
Copy link
Member

tech4GT commented Feb 26, 2018

@jywarren thanks a ton, now it's working, I'll be labelling prs with ready-to-merge from now on😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants