add getNeighbourPixel for dynamic module #204
Conversation
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
|
@jywarren is there anything else that should be added to this, we are not using the extra parameter anymore |
|
|
||
| /* neighbourpixels can be calculated by | ||
|
|
||
| this.getNeighbourPixel.fun(x,y) |
There was a problem hiding this comment.
Sorry, just one more! could we go with the American English spelling of Neighbor here? OR alias it so we can use both? 👍
And just curious, sorry if it's a silly question but why does getNeighborPixel have to be an object -- can't it just be getNeighborPixel()?
There was a problem hiding this comment.
@jywarren actually i have made it an object because pixelmanipulation remaps the options.getNeighbourpixel.fun to a new function which internally calls the original getneighbourpixels with the value of pixels it gets by closure. This remapping won't be possible if it's a function since we can't just say
options.getneighbourspixel = something else
And it feels kind of natural to use the same function defined in the same file
To avoid this we have 2 options either we move all the logic inside pixelmanipulation or use a different name than getneighbourpixels for actual function that will be called
There was a problem hiding this comment.
OK I left a comment on #207 -- that does look good!
|
Closing this in favour of #207 |
This is done by defining logic in the dynamic module, @jywarren please have a look
Signed-off-by: tech4GT varun.gupta1798@gmail.com