Material icon #217
Merged
Material icon #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
|
Depending on how big this is, do you want to exclude the icons in |
|
@jywarren Sorry i didn't understand? This icon will be useful for the demo so maybe it's not required in package.json , is this what you're asking? |
|
Oh, just that you can exclude things from the NPM package in package.json,
if there are heavy files. Let's not worry about it! And indeed, having the
demo in there fully is not a bad thing. Thanks!
…On Fri, Apr 20, 2018 at 10:04 AM, Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren> Sorry i didn't understand? This
icon will be useful for the demo so maybe it's not required in package.json
, is this what you're asking?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#217 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_J1t05FA-Gj1ioGlpz39D_OUIKNks5tqer9gaJpZM4TceMT>
.
|
|
@jywarren oh that makes sense, so this is ready to merge right or something else? |
|
It's ready but there is a merge conflict right now -- can you rebase or resolve? thanks!!! |
…nto materialIcon
|
@jywarren done👍 |
|
Perfect. Done!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jywarren in concert with #211