-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement importNewModule #294
Changes from 9 commits
da084ef
5ed3173
a89e0ca
62581d0
f5c226a
8c846ab
4b5eb1d
34cdc37
a450674
a670b15
40cff2b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -277,8 +277,18 @@ sequencer.insertSteps(index,module_name,optional_options); | |
|
||
return value: **`sequencer`** (To allow method chaining) | ||
|
||
### Importing an independent module | ||
|
||
The `loadNewModule` method can be used to import a new module inside sequencer. Modules can be downloaded via npm, yarn or cdn and are imported with a custom name. If you wish to load a new module at runtime, it will need to avoid usingrequire()-- unless it is compiled with a system like browserify or webpack. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. small typo here -- There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done!! |
||
|
||
```js | ||
const module = require('sequencer-moduleName') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should note if this is not usable in the browser. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and how to do it in a different way if you are in the browser, or what alternatives are? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So maybe a comment on this line about the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. so adding |
||
sequencer.loadNewModule('moduleName',module); | ||
``` | ||
|
||
|
||
## Method Chaining | ||
|
||
Methods can be chained on the Image Sequencer: | ||
* loadImage()/loadImages() can only terminate a chain. | ||
* run() can not be in the middle of the chain. | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait, shouldn't this be not image-sequencer but a specific module?