Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Modules.js #437

Closed
wants to merge 1 commit into from
Closed

Updated Modules.js #437

wants to merge 1 commit into from

Conversation

Jeewita
Copy link

@Jeewita Jeewita commented Oct 24, 2018

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@avsingh999
Copy link
Member

@Jeewita great work
please add a issue link
thank you :)

@aashna27
Copy link

Great work! 😄

@aashna27
Copy link

Just a little advice next time, link the issue with the pull request, by mentioning the issue number in the pull request. 😃

@avsingh999
Copy link
Member

@Jeewita great can you please add gif / Screenshot.
It would be easy to us , what you have done,
thank you 😃

@avsingh999
Copy link
Member

@Jeewita if you need any help then feel free to ask us :)

Copy link
Member

@Dhiraj240 Dhiraj240 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add issue link as its the only source which tells us as actually what you are solving.

'average': require('./modules/Average'),
'blend': require('./modules/Blend'),
'blur': require('./modules/Blur'),
'brightness': require('./modules/Brightness'),'channel': require('./modules/Channel'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why you wrote this 'channel': require('./modules/Channel'), because it is already present in next line?
So please remove this duplicate value

@tech4GT
Copy link
Member

tech4GT commented Oct 25, 2018

Hmm, @Jeewita @avsingh999 @aashna27 What issue does this solve? Arrange the modules in alphabetical order?

@tech4GT
Copy link
Member

tech4GT commented Oct 25, 2018

Wouldn't it be better to call .sort() on the loaded modules rather than arranging the modules this way?

@jywarren
Copy link
Member

I believe this has already been solved, but thank you!!!!

@jywarren jywarren closed this Nov 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants