-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Modules.js #437
Updated Modules.js #437
Conversation
@Jeewita great work |
Great work! 😄 |
Just a little advice next time, link the issue with the pull request, by mentioning the issue number in the pull request. 😃 |
@Jeewita great can you please add gif / Screenshot. |
@Jeewita if you need any help then feel free to ask us :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, please add issue link as its the only source which tells us as actually what you are solving.
'average': require('./modules/Average'), | ||
'blend': require('./modules/Blend'), | ||
'blur': require('./modules/Blur'), | ||
'brightness': require('./modules/Brightness'),'channel': require('./modules/Channel'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you wrote this 'channel': require('./modules/Channel'),
because it is already present in next line?
So please remove this duplicate value
Hmm, @Jeewita @avsingh999 @aashna27 What issue does this solve? Arrange the modules in alphabetical order? |
Wouldn't it be better to call |
I believe this has already been solved, but thank you!!!! |
Fixes #[Add issue number here.]
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!